From: Anand Jain <Anand.Jain@oracle.com>
To: Stefan Behrens <sbehrens@giantdisaster.de>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 3/3] btrfs-progs: handle error in the btrfs_prepare_device
Date: Tue, 17 Dec 2013 16:37:35 +0800 [thread overview]
Message-ID: <52B00D4F.5080403@oracle.com> (raw)
In-Reply-To: <52B004E1.706@giantdisaster.de>
>> + ret = btrfs_prepare_device(fddstdev, dstdev, 1, &dstdev_block_count, 0,
>> + &mixed, 0);
>> close(fddstdev);
>> + if (ret)
>> + goto leave_with_error;
>> fddstdev = -1;
yeah moved this 3 lines up. thanks.
> You change the code to call close(fddstdev) twice.
>
> [...]
>> +zero_dev_error:
>> + if (ret) {
>> + ret < 0 ?
>> + fprintf(stderr, "ERROR: failed to zero device start '%s' - %s\n",
>> + file, strerror(-ret)) :
>> + fprintf(stderr, "ERROR: failed to zero device start '%s' - %d\n",
>> + file, ret);
>
> This is not funny.
hmm. I am not sure what you mean ?
Thanks, Anand
next prev parent reply other threads:[~2013-12-17 8:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 2:33 [PATCH v2 1/3] btrfs-progs: don't replicate the stripe_len defines Anand Jain
2013-12-17 2:33 ` [PATCH v2 2/3] btrfs-progs: use stripe_len define here Anand Jain
2013-12-17 2:33 ` [PATCH v2 3/3] btrfs-progs: handle error in the btrfs_prepare_device Anand Jain
2013-12-17 8:01 ` Stefan Behrens
2013-12-17 8:37 ` Anand Jain [this message]
2013-12-17 14:18 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B00D4F.5080403@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).