linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Josef Bacik <jbacik@fb.com>
To: Wang Shilong <wangshilong1991@gmail.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 2/3] Btrfs: rework qgroup accounting
Date: Sat, 21 Dec 2013 09:13:35 -0500	[thread overview]
Message-ID: <52B5A20F.1050008@fb.com> (raw)
In-Reply-To: <D8610409-5BF3-4150-A0DF-DC9985169540@gmail.com>


On 12/21/2013 03:01 AM, Wang Shilong wrote:
> Hi Josef,
>
> I compie btrfs-next in my 32-bit machine, i get the following warnings:
>
> fs/btrfs/qgroup.c: In function ‘qgroup_excl_accounting’:
> fs/btrfs/qgroup.c:1503:12: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    qgroup = (struct btrfs_qgroup *)unode->aux;
>             ^
> fs/btrfs/qgroup.c: In function ‘qgroup_calc_old_refcnt’:
> fs/btrfs/qgroup.c:1571:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>     qg = (struct btrfs_qgroup *)tmp_unode->aux;
>          ^
> fs/btrfs/qgroup.c: In function ‘qgroup_account_deleted_refs’:
> fs/btrfs/qgroup.c:1665:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    qg = (struct btrfs_qgroup *)unode->aux;
>         ^
> fs/btrfs/qgroup.c: In function ‘qgroup_calc_new_refcnt’:
> fs/btrfs/qgroup.c:1705:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    qg = (struct btrfs_qgroup *)unode->aux;
>         ^
> fs/btrfs/qgroup.c: In function ‘qgroup_adjust_counters’:
> fs/btrfs/qgroup.c:1767:8: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>    qg = (struct btrfs_qgroup *)unode->aux;
>
> this patch is newly added into btrfs-next, so i think it is better that you fix these warnings locally .^_^

Crap I fixed part of these but not the other part, I'll fix it up and
push it out Monday. Thanks,

Josef

  reply	other threads:[~2013-12-21 14:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-18 21:07 Rework qgroup accounting Josef Bacik
2013-12-18 21:07 ` [PATCH 1/3] Btrfs: introduce lock_ref/unlock_ref Josef Bacik
2013-12-19  4:01   ` Dave Chinner
2013-12-19 14:37     ` Josef Bacik
2013-12-18 21:07 ` [PATCH 2/3] Btrfs: rework qgroup accounting Josef Bacik
2013-12-21  8:01   ` Wang Shilong
2013-12-21 14:13     ` Josef Bacik [this message]
2013-12-21  8:56   ` Wang Shilong
2013-12-21 14:14     ` Josef Bacik
2014-01-07 16:43     ` Josef Bacik
2014-01-08 14:33   ` David Sterba
2014-01-08 14:42     ` Josef Bacik
2013-12-18 21:07 ` [PATCH 3/3] Btrfs: add sanity tests for new qgroup accounting code Josef Bacik
2013-12-19  2:00 ` Rework qgroup accounting Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B5A20F.1050008@fb.com \
    --to=jbacik@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=wangshilong1991@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).