From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org, sbehrens@giantdisaster.de
Subject: Re: [PATCH v2 03/11] btrfs: Add nocheck_int mount option.
Date: Mon, 06 Jan 2014 08:51:31 +0800 [thread overview]
Message-ID: <52C9FE13.7040909@cn.fujitsu.com> (raw)
In-Reply-To: <20140103171308.GQ6498@twin.jikos.cz>
On Fri, 3 Jan 2014 18:13:08 +0100, David Sterba wrote:
> On Fri, Jan 03, 2014 at 02:10:26PM +0800, Qu Wenruo wrote:
>> Add nocheck_int mount option to disable integrity check with
>> remount option.
>>
>> + nocheck_int disables all the debug options above.
> I think this option is not needed, the integrity checker is a
> deveoplment functionality and used by people who know what they're
> doing. Besides this would need to clean up all the data structures that
> the checker uses (see eg. btrfsic_unmount that's called only if the
> mount option is used). I see little benefit compared to the amount of
> work to make sure that disabling the checker functionality in the middle
> works properly.
>
> david
>
That's right, since most people won't enable integrity check
until checking the all-yes config or running xfstests,
it's better not to add this option.
Qu
next prev parent reply other threads:[~2014-01-06 1:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 6:10 [PATCH v2 00/11] btrfs: Add missing pairing mount options Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 01/11] btrfs: Add "barrier" option to support "-o remount,barrier" Qu Wenruo
2014-01-03 8:44 ` Mike Fleetwood
2014-01-03 9:20 ` Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 02/11] btrfs: Add noautodefrag mount option Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 03/11] btrfs: Add nocheck_int " Qu Wenruo
2014-01-03 17:13 ` David Sterba
2014-01-06 0:51 ` Qu Wenruo [this message]
2014-01-03 6:10 ` [PATCH v2 04/11] btrfs: Add nodiscard " Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 05/11] btrfs: Add noenospc_debug " Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 06/11] btrfs: Add noflushoncommit " Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 07/11] btrfs: Add noinode_cache " Qu Wenruo
2014-01-03 17:52 ` David Sterba
2014-01-06 0:54 ` Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 08/11] btrfs: Add acl " Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 09/11] btrfs: Add datacow " Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 10/11] btrfs: Add datasum " Qu Wenruo
2014-01-03 6:10 ` [PATCH v2 11/11] btrfs: Add treelog " Qu Wenruo
2014-01-03 17:52 ` [PATCH v2 00/11] btrfs: Add missing pairing mount options Eric Sandeen
2014-01-06 0:58 ` Qu Wenruo
2014-01-03 17:58 ` David Sterba
2014-01-06 1:01 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C9FE13.7040909@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=sbehrens@giantdisaster.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).