From: Goffredo Baroncelli <kreijack@libero.it>
To: Gerhard Heift <gerhard@heift.name>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH RFCv2] new ioctl TREE_SEARCH_V2
Date: Mon, 27 Jan 2014 20:10:52 +0100 [thread overview]
Message-ID: <52E6AF3C.1070401@libero.it> (raw)
In-Reply-To: <1390829312-814-1-git-send-email-Gerhard@Heift.Name>
Hi,
On 2014-01-27 14:28, Gerhard Heift wrote:
> This patch series adds a new ioctl TREE_SEARCH_V2 with which we could store the
> results in a varying buffer. Now even items larger than 3992 bytes or a large
> amount of items can be returned.
One of the main strangeness of the current TREE_SEARCH ioctl, which I
found is the fact that the search was not in a "rectangular" region, but
in a "linear" region.
This is due the fact that after a ioctl call, we have to set the min_*
fields with the sh->{objectid,offset,type} +1 rounding to 0 if case of
overflow.
This because the min_* fields are both the "lower bound" of the search
and the "starting point" of the next search. Adding a new set of fields
named start_* could solve this issue.
I discussed this topic few years ago in [1].
Because we are introducing a new ioctl, is it possible to solve this
issue ? We could avoid some userspace<->kernelspace transition, which
seems be one of the goal of your patch.
BR
G.Baroncelli
[1] http://www.spinics.net/lists/linux-btrfs/msg07617.html
--
gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5
next prev parent reply other threads:[~2014-01-27 19:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 13:28 [PATCH RFCv2] new ioctl TREE_SEARCH_V2 Gerhard Heift
2014-01-27 13:28 ` [PATCH RFCv2 1/6] btrfs: search_ioctl accepts varying buffer Gerhard Heift
2014-01-27 17:19 ` David Sterba
2014-01-27 13:28 ` [PATCH RFCv2 2/6] btrfs: search_ioctl rejects unused setted values Gerhard Heift
2014-01-27 17:28 ` David Sterba
2014-01-28 0:32 ` Gerhard Heift
2014-01-29 17:12 ` David Sterba
2014-01-27 19:06 ` Martin Steigerwald
2014-01-27 13:28 ` [PATCH RFCv2 3/6] btrfs: copy_to_sk returns EOVERFLOW for too small buffer Gerhard Heift
2014-01-27 13:28 ` [PATCH RFCv2 4/6] btrfs: new ioctl TREE_SEARCH_V2 Gerhard Heift
2014-01-27 17:41 ` David Sterba
2014-01-28 0:33 ` Gerhard Heift
2014-01-27 13:28 ` [PATCH RFCv2 5/6] btrfs: search_ioctl: direct copy to userspace Gerhard Heift
2014-01-27 18:11 ` David Sterba
2014-01-28 0:35 ` Gerhard Heift
2014-01-27 13:28 ` [PATCH RFCv2 6/6] btrfs: in tree_search extent buffer lifetime Gerhard Heift
2014-01-27 17:15 ` [PATCH RFCv2] new ioctl TREE_SEARCH_V2 David Sterba
2014-01-27 19:10 ` Goffredo Baroncelli [this message]
2014-01-27 19:31 ` Hugo Mills
2014-01-27 21:33 ` Goffredo Baroncelli
2014-01-28 9:29 ` Anand Jain
2014-01-28 12:51 ` Gerhard Heift
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E6AF3C.1070401@libero.it \
--to=kreijack@libero.it \
--cc=gerhard@heift.name \
--cc=kreijack@inwind.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).