From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:10752 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755005AbaA1Pxb (ORCPT ); Tue, 28 Jan 2014 10:53:31 -0500 Message-ID: <52E7D273.5080905@fb.com> Date: Tue, 28 Jan 2014 10:53:23 -0500 From: Josef Bacik MIME-Version: 1.0 To: Wang Shilong , Subject: Re: [PATCH v3 1/2] Btrfs: rework ulist with list+rb_tree References: <1390816789-3901-1-git-send-email-wangsl.fnst@cn.fujitsu.com> In-Reply-To: <1390816789-3901-1-git-send-email-wangsl.fnst@cn.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 01/27/2014 04:59 AM, Wang Shilong wrote: > We are really suffering from now ulist's implementation, some developers > gave their try, and i just gave some of my ideas for things: > > 1. use list+rb_tree instead of arrary+rb_tree > > 2. add cur_list to iterator rather than ulist structure. > > 3. add seqnum into every node when they are added, this is > used to do selfcheck when iterating node. > > I noticed Zach Brown's comments before, long term is to kick off > ulist implementation, however, for now, we need at least avoid > arrary from ulist. > > Cc: Liu Bo > Cc: Josef Bacik > Cc: Zach Brown > Signed-off-by: Wang Shilong > --- > v2->v3: > only do selfchecks with CONFIG_BTRFS_DEBUG enabled(Thanks to Josef!) > update ulist's comments since they are out of date. > v1->v2: > add RFC title since this patch needs more reviews and comments. > fix a used after free bug in ulist_fini(). I like the patch but it doesn't build since things like qgroups rely on ulist->nnodes. You need to fix that in your patch and make sure this stuff compiles. Thanks, Josef