From: Josef Bacik <jbacik@fb.com>
To: Roger Binns <rogerb@rogerbinns.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: disable snapshot aware defrag for now
Date: Tue, 4 Feb 2014 09:07:34 -0500 [thread overview]
Message-ID: <52F0F426.7030605@fb.com> (raw)
In-Reply-To: <lcpm87$15e$1@ger.gmane.org>
On 02/03/2014 10:19 PM, Roger Binns wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 03/02/14 09:27, Josef Bacik wrote:
>> It is so totally broken that I don't want it being turned on by anybody
>> who can't edit this and change it themselves.
> The symptoms I saw are huge amounts of kernel memory consumption, possibly
> till exhaustion of swap. Are there other ways in which is it broken (eg
> corruption)?
>
> Also is this patch making its way to the various stables?
No corruption, and frankly if you had just small files and a small
number of snapshots it worked just fine, but otherwise it would use all
of your ram. I cc'ed stable@ so it should make it back to all the
stables. Thanks,
Josef
prev parent reply other threads:[~2014-02-04 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 21:05 [PATCH] Btrfs: disable snapshot aware defrag for now Josef Bacik
2014-02-03 14:48 ` David Sterba
2014-02-03 17:27 ` Josef Bacik
2014-02-04 3:19 ` Roger Binns
2014-02-04 14:07 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F0F426.7030605@fb.com \
--to=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=rogerb@rogerbinns.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).