From: Anand Jain <Anand.Jain@oracle.com>
To: dsterba@suse.cz, Goffredo Baroncelli <kreijack@libero.it>,
Hugo Mills <hugo@carfax.org.uk>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: introduce BTRFS_IOC_GET_DEVS
Date: Fri, 07 Feb 2014 18:08:56 +0800 [thread overview]
Message-ID: <52F4B0B8.2080804@oracle.com> (raw)
In-Reply-To: <20140206220535.GV1364@suse.cz>
Thanks for the comments.
mainly here sysfs way defeats the purpose - debug as
mentioned. Sysfs would/should show only mounted disks,
the ioctl way doesn't have such a limitation (of course
as I commented memory dump way would have been best choice
but I got stuck with that approach if anybody wants to give
a try with that approach you are most welcome).
IMO no harm to have both sysfs way and ioctl way let user
or developer use which were is suitable in their context.
Thanks, Anand
On 02/07/2014 06:05 AM, David Sterba wrote:
> On Thu, Feb 06, 2014 at 09:09:57PM +0100, Goffredo Baroncelli wrote:
>>> With 3.14 the sysfs interface is available, but the devices under
>>> /sys/fs/btrfs/<fs-uuid>/devices/...
>>> are symlinks to the sysfs devices, so this btrfs-specific device
>>> information has to be located in a separate directory.
>>
>> yes please; it would scale better than the ioctl()s; anyway I suggest 1
>> file per property, and not "...one file that holds all the stats
>> about the device"
>
> Well, we can do both, I don't have a preference and both make sense.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-02-07 9:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-27 8:52 [PATCH] dump device list as seen by the kernel Anand Jain
2014-01-27 8:52 ` [PATCH] btrfs: introduce BTRFS_IOC_GET_DEVS Anand Jain
2014-01-27 8:47 ` Hugo Mills
2014-01-27 9:08 ` Anand Jain
2014-02-06 19:49 ` David Sterba
2014-02-06 20:09 ` Goffredo Baroncelli
2014-02-06 22:05 ` David Sterba
2014-02-07 10:08 ` Anand Jain [this message]
2014-02-07 10:20 ` Hugo Mills
2014-02-12 16:01 ` David Sterba
2014-02-12 16:15 ` Hugo Mills
2014-02-25 17:45 ` David Sterba
2014-02-26 2:34 ` Anand Jain
2014-01-27 8:56 ` [PATCH] btrfs-progs: introduce btrfs-devlist Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F4B0B8.2080804@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=hugo@carfax.org.uk \
--cc=kreijack@libero.it \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).