From: Josef Bacik <jbacik@fb.com>
To: cwillu <cwillu@cwillu.com>
Cc: Hugo Mills <hugo@carfax.org.uk>,
"lin >> linux-btrfs@vger.kernel.org"
<linux-btrfs@vger.kernel.org>
Subject: Re: What to do about df and btrfs fi df
Date: Mon, 10 Feb 2014 13:41:23 -0500 [thread overview]
Message-ID: <52F91D53.5060902@fb.com> (raw)
In-Reply-To: <CAE5mzvhc0FCL81=ajAFyzHK6L1vP2uuQrjf6UfMX-vDxH+-pKQ@mail.gmail.com>
On 02/10/2014 01:36 PM, cwillu wrote:
> IMO, used should definitely include metadata, especially given that we
> inline small files.
>
> I can convince myself both that this implies that we should roll it
> into b_avail, and that we should go the other way and only report the
> actual used number for metadata as well, so I might just plead
> insanity here.
>
I could be convinced to do this. So we have
total: (total disk bytes) / (raid multiplier)
used: (total used in data block groups) +
(total used in metadata block groups)
avail: total - (total used in data block groups +
total metadata block groups)
That seems like the simplest to code up. Then we can argue about
whether to use the total metadata size or just the used metadata size
for b_avail. Seem reasonable?
Josef
next prev parent reply other threads:[~2014-02-10 18:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-10 16:41 What to do about df and btrfs fi df Josef Bacik
2014-02-10 17:06 ` Hugo Mills
2014-02-10 18:24 ` cwillu
2014-02-10 18:28 ` Josef Bacik
2014-02-10 18:36 ` cwillu
2014-02-10 18:41 ` Josef Bacik [this message]
2014-02-10 18:54 ` cwillu
2014-02-10 19:05 ` Hugo Mills
2014-02-11 17:36 ` David Sterba
2014-02-17 17:08 ` David Sterba
2014-02-18 8:33 ` Goswin von Brederlow
2014-02-18 16:43 ` David Sterba
2014-02-11 1:02 ` Roger Binns
2014-02-11 3:13 ` cwillu
2014-02-11 3:35 ` ronnie sahlberg
2014-02-11 19:58 ` Roger Binns
2014-02-10 22:14 ` Goffredo Baroncelli
2014-02-10 22:26 ` Goffredo Baroncelli
2014-02-10 22:56 ` cwillu
2014-02-11 13:14 ` Josef Bacik
2014-02-11 18:20 ` Goffredo Baroncelli
2014-02-11 18:33 ` Josef Bacik
2014-02-11 18:46 ` Goffredo Baroncelli
2014-02-11 18:56 ` Hugo Mills
2014-02-12 21:03 ` Goffredo Baroncelli
2014-02-11 20:53 ` Sandy McArthur
2014-02-12 3:09 ` Kostia Khlebopros
2014-02-12 21:12 ` Goffredo Baroncelli
2014-02-12 3:55 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52F91D53.5060902@fb.com \
--to=jbacik@fb.com \
--cc=cwillu@cwillu.com \
--cc=hugo@carfax.org.uk \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).