Re: What to do about df and btrfs fi df

[Josef Bacik <jbacik@fb.com>]

On 02/10/2014 05:26 PM, Goffredo Baroncelli wrote:
> On 02/10/2014 05:41 PM, Josef Bacik wrote:
>> ===== New and improved btrfs fi df =====
>>
>> Since people using this tool are already going to be better informed
>> and since we are already given the block group flags we can go ahead
>> and do the raid multiplier in btrfs-progs and spit out the adjusted
>> numbers rather than the raw numbers we get from the ioctl.  This will
>> just be a progs thing and that way we can possibly add an option to
>> not apply the multipliers and just get the raw output.
>
> In the past [1] I proposed the following approach.
>
> $ sudo btrfs filesystem df /mnt/btrfs1/
> Disk size:		 400.00GB
> Disk allocated:		   8.04GB
> Disk unallocated:	 391.97GB
> Used:			  11.29MB
> Free (Estimated):	 250.45GB	(Max: 396.99GB, min: 201.00GB)
> Data to disk ratio:	     63 %
>
> The space was given in terms of "disk space" and in terms of
> "filesystem space". Other that there is an indication of an estimation of
> the free space, with the pessimistic and optimistic values.
>
> [1] See "[PATCH V3][BTRFS-PROGS] Enhance btrfs fi df with raid5/6 support"
> dated 03/10/2013 01:17 PM
>

The problem I had with this patch was it didn't give me a way to get the 
original output.  I as a developer really need to have the raw dump of 
the block group info as I'm doing stuff.  So I like this output, but I 
still need my old output, if you fix that part up I'll review/ack it. 
Thanks,

Josef