linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Anton Mitterer <calestyo@scientia.org>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, linux-btrfs@vger.kernel.org
Subject: Re: call trace when btrfs-check tries to write on ro-blockdev
Date: Wed, 21 Sep 2022 05:43:16 +0200	[thread overview]
Message-ID: <52bf0daaa1f88fe1069f4871e28ca18a90d1d5c1.camel@scientia.org> (raw)
In-Reply-To: <6d72763c-d024-3224-be8e-0ade32540883@gmx.com>

On Wed, 2022-09-21 at 10:40 +0800, Qu Wenruo wrote:
> But my concern is, why this is not reported at fs open time?

At first I also wanted to suggest to not even do the (possibly lengthy
opening) if it's anyway "clear" that it would fail (because of the --
clear-space-cache request and the blockdev being ro).

However... if e.g. --clear-space-cache is used, but the device wouldn't
have any space cache... then it could still succeed, even if it was ro,
right?
So maybe for that case it would make sense to try.


> Let me dig deeper into the case.

Thanks.


Chris.

  reply	other threads:[~2022-09-21  3:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-21  2:29 call trace when btrfs-check tries to write on ro-blockdev Christoph Anton Mitterer
2022-09-21  2:40 ` Qu Wenruo
2022-09-21  3:43   ` Christoph Anton Mitterer [this message]
2022-09-23 10:39     ` Qu Wenruo
2022-09-23 18:53       ` Christoph Anton Mitterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52bf0daaa1f88fe1069f4871e28ca18a90d1d5c1.camel@scientia.org \
    --to=calestyo@scientia.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).