From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cn.fujitsu.com ([222.73.24.84]:52568 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753936AbaBRHO4 (ORCPT ); Tue, 18 Feb 2014 02:14:56 -0500 Message-ID: <53030400.7010607@cn.fujitsu.com> Date: Tue, 18 Feb 2014 14:56:00 +0800 From: Wang Shilong MIME-Version: 1.0 To: Dave Chinner CC: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH 1/3] xfstests/btrfs: add qgroup rescan stress test References: <1392261539-28903-1-git-send-email-wangsl.fnst@cn.fujitsu.com> <20140218064659.GA28666@dastard> In-Reply-To: <20140218064659.GA28666@dastard> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 02/18/2014 02:46 PM, Dave Chinner wrote: > On Thu, Feb 13, 2014 at 11:18:57AM +0800, Wang Shilong wrote: >> Test flow is to run fsstress after triggering quota rescan. >> the ruler is simple, we just remove all files and directories, >> sync filesystem and see if qgroup's ref and excl are nodesize. >> >> Signed-off-by: Wang Shilong >> --- >> tests/btrfs/038 | 75 +++++++++++++++++++++++++++++++++++++++++++++++++++++ >> tests/btrfs/038.out | 3 +++ >> tests/btrfs/group | 1 + >> 3 files changed, 79 insertions(+) >> create mode 100644 tests/btrfs/038 >> create mode 100644 tests/btrfs/038.out >> >> diff --git a/tests/btrfs/038 b/tests/btrfs/038 >> new file mode 100644 >> index 0000000..f6bd872 >> --- /dev/null >> +++ b/tests/btrfs/038 >> @@ -0,0 +1,75 @@ >> +#! /bin/bash >> +# FSQA Test No. btrfs/038 >> +# >> +# Quota rescan stress test, we run fsstress and quota rescan concurrently >> +# >> +#----------------------------------------------------------------------- >> +# Copyright (C) 2014 Fujitsu. All rights reserved. >> +# >> +# This program is free software; you can redistribute it and/or >> +# modify it under the terms of the GNU General Public License as >> +# published by the Free Software Foundation. >> +# >> +# This program is distributed in the hope that it would be useful, >> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> +# GNU General Public License for more details. >> +# >> +# You should have received a copy of the GNU General Public License >> +# along with this program; if not, write the Free Software Foundation, >> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA >> +# >> +#----------------------------------------------------------------------- >> +# >> + >> +seq=`basename $0` >> +seqres=$RESULT_DIR/$seq >> +echo "QA output created by $seq" >> + >> +here=`pwd` >> +tmp=/tmp/$$ >> +status=1 >> + >> +_cleanup() >> +{ >> + rm -f $tmp.* >> +} >> +trap "_cleanup; exit \$status" 0 1 2 3 15 >> + >> +# get standard environment, filters and checks >> +. ./common/rc >> +. ./common/filter >> + >> +# real QA test starts here >> +_need_to_be_root >> +_supported_fs btrfs >> +_supported_os Linux >> +_require_scratch >> + >> +rm -f $seqres.full >> + >> +run_check _scratch_mkfs "-b 2g --nodesize 4096" >> +run_check _scratch_mount >> + >> +# -w ensures that the only ops are ones which cause write I/O >> +run_check $FSSTRESS_PROG -d $SCRATCH_MNT -w -p 5 -n 1000 \ >> + $FSSTRESS_AVOID >&/dev/null >> + >> +run_check $BTRFS_UTIL_PROG subvolume snapshot $SCRATCH_MNT \ >> + $SCRATCH_MNT/snap1 >>$seqres.full 2>&1 >> + >> +run_check $FSSTRESS_PROG -d $SCRATCH_MNT/snap1 -w -p 5 -n 1000 \ >> + $FSSTRESS_AVOID >&/dev/null >> + >> +run_check $BTRFS_UTIL_PROG quota enable $SCRATCH_MNT >> +run_check $BTRFS_UTIL_PROG quota rescan -w $SCRATCH_MNT > "run_check considered harmful." > > http://oss.sgi.com/archives/xfs/2014-02/msg00482.html > > Once I've committed Filipe's run_btrfs_util_prog, can you update > this series to remove all the unnecessary run_check calls and > repost? Thanks! No problem. ^_^ Thanks, Wang > > Cheers, > > Dave.