From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cn.fujitsu.com ([222.73.24.84]:22918 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751600AbaBXLE1 (ORCPT ); Mon, 24 Feb 2014 06:04:27 -0500 Message-ID: <530B26C9.9060606@cn.fujitsu.com> Date: Mon, 24 Feb 2014 19:02:33 +0800 From: Wang Shilong MIME-Version: 1.0 To: ZhangZhen CC: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org Subject: Re: [PATCH for xfstests] xfstests: fix to make tests/btrfs/013 really work References: <530AF3E3.9060202@huawei.com> <530B2418.20905@huawei.com> In-Reply-To: <530B2418.20905@huawei.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: Hi Zhang, On 02/24/2014 06:51 PM, ZhangZhen wrote: > The test 013 couldn't work because here lacked "start". > This patch fix it. > > Signed-off-by: Zhang Zhen > --- > tests/btrfs/013 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/btrfs/013 b/tests/btrfs/013 > index 7620fcc..fb81663 100644 > --- a/tests/btrfs/013 > +++ b/tests/btrfs/013 > @@ -72,7 +72,7 @@ _check_csum_error() > } > $XFS_IO_PROG -f -c "falloc 0 1M" -c "pwrite 16k 8k" -c "fsync" \ > $SCRATCH_MNT/foo > $seqres.full 2>&1 > -$BTRFS_UTIL_PROG filesystem balance $SCRATCH_MNT >> $seqres.full 2>&1 || \ > +$BTRFS_UTIL_PROG filesystem balance start $SCRATCH_MNT >> $seqres.full 2>&1 || \ > _fail "balance failed" Due to historical reasons, we have 'btrfs file balance <>'.. Until now, it is also ok to run 'btrfs file balance ', and it has equal effect as 'btrfs filesystem balance start'. Anyway, using latest 'btrfs file balance start ' is better than previous codes..but patch's title is not right any more... BTW,Dave Chinner previously pointed out that we need a cleanup, url can be seen: http://oss.sgi.com/archives/xfs/2014-02/msg00482.html Thanks, Wang > _scratch_unmount > _scratch_mount