From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cn.fujitsu.com ([222.73.24.84]:58106 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752421AbaCKBZP (ORCPT ); Mon, 10 Mar 2014 21:25:15 -0400 Message-ID: <531E657A.2000803@cn.fujitsu.com> Date: Tue, 11 Mar 2014 09:23:06 +0800 From: Wang Shilong MIME-Version: 1.0 To: Josef Bacik CC: Shilong Wang , linux-btrfs Subject: Re: [PATCH] Btrfs-progs: fsck: disable --init-extent-tree option when using snapshots References: <1394447961-27981-1-git-send-email-wangsl.fnst@cn.fujitsu.com> <531DDF4E.3090600@fb.com> In-Reply-To: <531DDF4E.3090600@fb.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 03/10/2014 11:50 PM, Josef Bacik wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 03/10/2014 08:12 AM, Shilong Wang wrote: >> Hi Josef, >> >> As i haven't thought any better ideas to rebuild extent tree which >> contains extent that owns 'FULL BACKREF' flag. >> >> Considering an extent's refs can be equal or more than 1 if this >> extent has *FULL BACKREF* flag, so we could not make sure an >> extent's flag by only searching fs/file tree any more. >> >> So until now, i just disable this option if snapshots exists, >> please correct me if i miss something here. Or you have any better >> ideas to solve this problem.~_~ >> >> > I thought the fsck stuff rebuilds full backref refs properly, does it > not? If it doesn't we need to fix that, however I'm fine with > disabling the option if snapshots exist for the time being. Thanks, If there are no snapshots, --init-extent-tree can works as expected. I just have not thought a better idea to rebuild extent tree if we do have snapshots which means we may have an extent with *FULL BACKREF* flag. Thanks, Wang > > Josef > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1 > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ > > iQIcBAEBAgAGBQJTHd9NAAoJEANb+wAKly3BYCYP/0iTaaa7w0SnfXtgjoVyX+nT > +e0Pa46zeKzpTujotCDb9E/2PBesCAvA4Psog3rkfsqJ2nXN9cERN4E6/JG4nAHh > Hv4KPo+w+tCkC4U2wSoDivYrVk9G5SH25ewkgW6iheSYNIlm+PLbOQz9DzGjCFDp > 51J9tG5E010siOyhlLCyGj8ZTj+gXuoQVWKCS8dOpCLMrbYYjMDXa562hqWaLoS/ > t3eSfP7Tnnpl43NiMZI4fWrzmlFa5lba5iJmG59FeyiseRH4Zrhee4St1L1xDL5A > /6f3tJJT7DJjRRJFv0nJAOvOPyFaK8bMaYmOQJg6VrhcyPKM3BxBVEab3HrmQ7jt > LCMWobpIcM7e5BugmbTGGsFymhv05SQgvYGzpzRVXdsSzqubuqTcXwloNU5RyyFF > sXT9IiW9wAibHe7mDN7V6nfo1bVfHsjvSVi1rqz4/zFOWyh8oqxfEhxUJIWhfFsn > j0WJevvqKnjBJujyyuQpL13tzh69qei0AHOEme3R46BSRMnyuacy/WOeyo4VXPcn > 0GIeWbngAIWF/quhoQGkvofRMlPgftiDge8uz9pbm3IEKeiP9dQ/HvKsIHMKjnKW > 3dEBvMV/CSUQNek4VjO1ALefTRZQvJVL8Wxdij4W+djJw/uVX7fOhuqdkqyfM3FY > CKSB3HUSUtDCammsvgQA > =OT98 > -----END PGP SIGNATURE----- > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >