From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 4/4] btrfs-progs: Fix the return value when executing 'btrfs pro get' on a uncompress file.
Date: Wed, 23 Apr 2014 09:22:02 +0800 [thread overview]
Message-ID: <535715BA.4010509@cn.fujitsu.com> (raw)
In-Reply-To: <20140422123732.GA2027@twin.jikos.cz>
-------- Original Message --------
Subject: Re: [PATCH v2 4/4] btrfs-progs: Fix the return value when
executing 'btrfs pro get' on a uncompress file.
From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Date: 2014年04月22日 20:37
> On Tue, Apr 15, 2014 at 05:22:24PM +0800, Qu Wenruo wrote:
>> When executing 'btrfs pro get' on a file which is not compressed, return
>> value will always be 50 since prop_compress() return -ENOATTR.
>>
>> But the codes have already check the errno to avoid unnecessary error
>> message, so the return value should also set to 0.
>>
>> Signed-off-by: Qu Wenruo <quwenro@cn.fujitsu.com>
> JFYI, I've edited the subject and changelog, let's use the 'prop'
> abbreviation for properties.
Thanks for that.
My poor English seems always to be a problem. :(
Qu
prev parent reply other threads:[~2014-04-23 1:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 9:22 [PATCH v2 4/4] btrfs-progs: Fix the return value when executing 'btrfs pro get' on a uncompress file Qu Wenruo
2014-04-15 9:27 ` Filipe David Manana
2014-04-22 12:37 ` David Sterba
2014-04-23 1:22 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535715BA.4010509@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).