[PATCH v2] tests: btrfs/237: skip test on devices with conventional zones

[PATCH v2] tests: btrfs/237: skip test on devices with conventional zones

[Johannes Thumshirn]

From: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Skip btrfs/237 on devices with conventional zones, as we cannot force data
allocation on a sequential zone at the moment and conventional zones
cannot be reset, making the test invalid.

Furthermore limit the output of get_data_bg() and get_data_bg_physical()
to the first address.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

---
Changes in v2:
- Use 'tail' instead of 'head'
---
 tests/btrfs/237 | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/tests/btrfs/237 b/tests/btrfs/237
index 2839f6e4..675f4c42 100755
--- a/tests/btrfs/237
+++ b/tests/btrfs/237
@@ -28,7 +28,8 @@ get_data_bg()
 {
 	$BTRFS_UTIL_PROG inspect-internal dump-tree -t CHUNK $SCRATCH_DEV |\
 		grep -A 1 "CHUNK_ITEM" | grep -B 1 "type DATA" |\
-		grep -Eo "CHUNK_ITEM [[:digit:]]+" | cut -d ' ' -f 2
+		grep -Eo "CHUNK_ITEM [[:digit:]]+" | cut -d ' ' -f 2 |\
+		tail -n 1
 }
 
 get_data_bg_physical()
@@ -36,9 +37,13 @@ get_data_bg_physical()
 	# Assumes SINGLE data profile
 	$BTRFS_UTIL_PROG inspect-internal dump-tree -t CHUNK $SCRATCH_DEV |\
 		grep -A 4 CHUNK_ITEM | grep -A 3 'type DATA\|SINGLE' |\
-	        grep -Eo 'offset [[:digit:]]+'| cut -d ' ' -f 2
+	        grep -Eo 'offset [[:digit:]]+'| cut -d ' ' -f 2 |\
+		tail -n 1
 }
 
+$BLKZONE_PROG report $SCRATCH_DEV | grep -q -e "nw" && \
+	_notrun "test is unreliable on devices with conventional zones"
+
 sdev="$(_short_dev $SCRATCH_DEV)"
 zone_size=$(($(cat /sys/block/${sdev}/queue/chunk_sectors) << 9))
 fssize=$((zone_size * 16))
-- 
2.50.1

Re: [PATCH v2] tests: btrfs/237: skip test on devices with conventional zones

[Anand Jain]

On 18/8/25 15:23, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 
> Skip btrfs/237 on devices with conventional zones, as we cannot force data
> allocation on a sequential zone at the moment and conventional zones
> cannot be reset, making the test invalid.
> 
> Furthermore limit the output of get_data_bg() and get_data_bg_physical()
> to the first address.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 
> ---
> Changes in v2:
> - Use 'tail' instead of 'head'

Reviewed-by: Anand Jain <anand.jain@oracle.com>

Thanks, Anand

> ---
>   tests/btrfs/237 | 9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/btrfs/237 b/tests/btrfs/237
> index 2839f6e4..675f4c42 100755
> --- a/tests/btrfs/237
> +++ b/tests/btrfs/237
> @@ -28,7 +28,8 @@ get_data_bg()
>   {
>   	$BTRFS_UTIL_PROG inspect-internal dump-tree -t CHUNK $SCRATCH_DEV |\
>   		grep -A 1 "CHUNK_ITEM" | grep -B 1 "type DATA" |\
> -		grep -Eo "CHUNK_ITEM [[:digit:]]+" | cut -d ' ' -f 2
> +		grep -Eo "CHUNK_ITEM [[:digit:]]+" | cut -d ' ' -f 2 |\
> +		tail -n 1
>   }
>   
>   get_data_bg_physical()
> @@ -36,9 +37,13 @@ get_data_bg_physical()
>   	# Assumes SINGLE data profile
>   	$BTRFS_UTIL_PROG inspect-internal dump-tree -t CHUNK $SCRATCH_DEV |\
>   		grep -A 4 CHUNK_ITEM | grep -A 3 'type DATA\|SINGLE' |\
> -	        grep -Eo 'offset [[:digit:]]+'| cut -d ' ' -f 2
> +	        grep -Eo 'offset [[:digit:]]+'| cut -d ' ' -f 2 |\
> +		tail -n 1
>   }
>   
> +$BLKZONE_PROG report $SCRATCH_DEV | grep -q -e "nw" && \
> +	_notrun "test is unreliable on devices with conventional zones"
> +
>   sdev="$(_short_dev $SCRATCH_DEV)"
>   zone_size=$(($(cat /sys/block/${sdev}/queue/chunk_sectors) << 9))
>   fssize=$((zone_size * 16))