From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:43258 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127AbaEHSl4 (ORCPT ); Thu, 8 May 2014 14:41:56 -0400 Message-ID: <536BCFF3.70302@redhat.com> Date: Thu, 08 May 2014 13:41:55 -0500 From: Eric Sandeen MIME-Version: 1.0 To: Josef Bacik , linux-btrfs@vger.kernel.org, xfs@oss.sgi.com Subject: Re: [PATCH] xfstests: fix flink test V2 References: <1399574310-13718-1-git-send-email-jbacik@fb.com> In-Reply-To: <1399574310-13718-1-git-send-email-jbacik@fb.com> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 5/8/14, 1:38 PM, Josef Bacik wrote: > I don't have flink support in my xfsprogs, but it doesn't fail with "command not > found" or whatever, it fails because I don't have the -T option, whereas Eric > gets an error about $TEST_DIR being a directory because his xfs_io tries to open > the directory first before it parses the options. So fix this by checking flink > with these two cases and don't run if we hit either of them. Thanks, > > Signed-off-by: Josef Bacik Looks good to me, thanks. Reviewed-by: Eric Sandeen > --- > V1->V2: check for "Is a directory" errors that Eric mentioned, move test up into > the flink specific case. > > common/rc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/common/rc b/common/rc > index 5c13db5..f37b310 100644 > --- a/common/rc > +++ b/common/rc > @@ -1248,6 +1248,8 @@ _require_xfs_io_command() > "flink" ) > testio=`$XFS_IO_PROG -T -F -c "flink $testfile" \ > $TEST_DIR 2>&1` > + echo $testio | egrep -q "invalid option|Is a directory" && \ > + _notrun "xfs_io $command support is missing" > ;; > *) > testio=`$XFS_IO_PROG -c "$command help" 2>&1` >