From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cn.fujitsu.com ([59.151.112.132]:4214 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754438AbaEIBUs (ORCPT ); Thu, 8 May 2014 21:20:48 -0400 Message-ID: <536C2C99.6020506@cn.fujitsu.com> Date: Fri, 9 May 2014 09:17:13 +0800 From: Wang Shilong MIME-Version: 1.0 To: Josef Bacik CC: , Subject: Re: [PATCH v2 1/3] xfstests/btrfs: add qgroup rescan stress test References: <1394423051-17356-1-git-send-email-wangsl.fnst@cn.fujitsu.com> <536A9E73.90802@fb.com> <536AFC3B.7070502@cn.fujitsu.com> <536BCDF7.7070404@fb.com> In-Reply-To: <536BCDF7.7070404@fb.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Sender: linux-btrfs-owner@vger.kernel.org List-ID: On 05/09/2014 02:33 AM, Josef Bacik wrote: > On 05/07/2014 11:38 PM, Wang Shilong wrote: >> On 05/08/2014 04:58 AM, Josef Bacik wrote: >>> On 03/09/2014 11:44 PM, Wang Shilong wrote: >>>> Test flow is to run fsstress after triggering quota rescan. >>>> the ruler is simple, we just remove all files and directories, >>>> sync filesystem and see if qgroup's ref and excl are nodesize. >>>> >>>> Signed-off-by: Wang Shilong >>>> --- >>>> v1->v2: >>>> switch into new helper _run_btrfs_util_prog() >>>> --- >>>> tests/btrfs/041 | 76 >>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++ >>>> tests/btrfs/041.out | 3 +++ >>>> tests/btrfs/group | 1 + >>>> 3 files changed, 80 insertions(+) >>>> create mode 100644 tests/btrfs/041 >>>> create mode 100644 tests/btrfs/041.out >>>> >>>> diff --git a/tests/btrfs/041 b/tests/btrfs/041 >>>> new file mode 100644 >>>> index 0000000..92bd080 >>>> --- /dev/null >>>> +++ b/tests/btrfs/041 >>>> @@ -0,0 +1,76 @@ >>>> +#! /bin/bash >>>> +# FSQA Test No. btrfs/041 >>>> +# >>>> +# Quota rescan stress test, we run fsstress and quota rescan >>>> concurrently >>>> +# >>>> +#----------------------------------------------------------------------- >>>> >>>> >>>> +# Copyright (C) 2014 Fujitsu. All rights reserved. >>>> +# >>>> +# This program is free software; you can redistribute it and/or >>>> +# modify it under the terms of the GNU General Public License as >>>> +# published by the Free Software Foundation. >>>> +# >>>> +# This program is distributed in the hope that it would be useful, >>>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> +# GNU General Public License for more details. >>>> +# >>>> +# You should have received a copy of the GNU General Public License >>>> +# along with this program; if not, write the Free Software >>>> Foundation, >>>> +# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA >>>> +# >>>> +#----------------------------------------------------------------------- >>>> >>>> >>>> +# >>>> + >>>> +seq=`basename $0` >>>> +seqres=$RESULT_DIR/$seq >>>> +echo "QA output created by $seq" >>>> + >>>> +here=`pwd` >>>> +tmp=/tmp/$$ >>>> +status=1 >>>> + >>>> +_cleanup() >>>> +{ >>>> + cd / >>>> + rm -f $tmp.* >>>> +} >>>> +trap "_cleanup; exit \$status" 0 1 2 3 15 >>>> + >>>> +# get standard environment, filters and checks >>>> +. ./common/rc >>>> +. ./common/filter >>>> + >>>> +# real QA test starts here >>>> +_need_to_be_root >>>> +_supported_fs btrfs >>>> +_supported_os Linux >>>> +_require_scratch >>>> + >>>> +rm -f $seqres.full >>>> + >>>> +run_check _scratch_mkfs "-b 1g --nodesize 4096" >>>> +run_check _scratch_mount >>>> + >>> >>> Add "-o nospace_cache" here please, otherwise I don't get the same >>> output. >> >> I am little confused why we need specify this mount option explicitly? >> As far as i know, space cache is not included into qgroup accounting >> space. >> > > It is. Thanks, Free space cache are inserted in tree root, they can not be shared with other trees(fs/file tree). So normal fs/file tree's qgroup accounting is independeng of free space cache. With or without the option, subvolume qgroup's value should not have any differences. Did i miss something here?:-) Thanks, Wang > > Josef > > . >