From: Zhang Zhen <zhenzhang.zhang@huawei.com>
To: <clm@fb.com>, <jbacik@fb.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
David Taylor <davidt-btrfs@yadt.co.uk>
Subject: Re: [PATCH] btrfs: replace simple_strtoul() with kstrtoul()
Date: Tue, 13 May 2014 09:44:42 +0800 [thread overview]
Message-ID: <5371790A.6010102@huawei.com> (raw)
In-Reply-To: <20140512112808.GA5103@yadt.co.uk>
On 2014/5/12 19:28, David Taylor wrote:
> On Mon, 12 May 2014, Zhang Zhen wrote:
>
>> use the newer and more pleasant kstrtoul() to replace simple_strtoul(),
>> because simple_strtoul() is marked for obsoletion.
> [...]
>> - devid = simple_strtoull(devstr, &end, 10);
>> + devid = kstrtoul(devstr, &end, 10);
>
> kstrtoul appears to take its arguments in a different order:
>
> unsigned long long simple_strtoull(const char * cp,
> char ** endp, unsigned int base);
>
> int kstrtoul(const char *s, unsigned int base, unsigned long *res);
>
Hi David,
You are right, i made a mistake.
I will soon send the right one .
Thanks for your reply.
next prev parent reply other threads:[~2014-05-13 1:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1399892355-3781-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-05-12 11:01 ` [PATCH] btrfs: replace simple_strtoul() with kstrtoul() Zhang Zhen
2014-05-12 11:28 ` David Taylor
2014-05-13 1:44 ` Zhang Zhen [this message]
[not found] <1399947478-11287-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-05-13 2:22 ` Zhang Zhen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5371790A.6010102@huawei.com \
--to=zhenzhang.zhang@huawei.com \
--cc=clm@fb.com \
--cc=davidt-btrfs@yadt.co.uk \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).