From: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
To: <dsterba@suse.cz>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v2 1/4] Btrfs-progs: fsck: only allow partial opening under repair mode
Date: Tue, 3 Jun 2014 11:35:12 +0800 [thread overview]
Message-ID: <538D4270.4030808@cn.fujitsu.com> (raw)
In-Reply-To: <20140602161856.GD22324@twin.jikos.cz>
On 06/03/2014 12:18 AM, David Sterba wrote:
> On Thu, May 29, 2014 at 05:59:56PM +0800, Wang Shilong wrote:
>> The reason that we allow partial opening is that sometimes,
>> we may have some corrupted trees.(for example extent tree), for
>> fsck repair case, the broken tree may be rebuilt later.
>>
>> So if users only want to do check but not repair anything, this
>> patch will make fsck return failure as soon as possible and
>> tell users that some critial roots have been corrupted.
> Ok, that partially answers my question under v1. This would be a
> different mode, eg. a fast check, that would bail out quickly as you
> intend. I'd really want to keep the (full) check and repair to do the
Mm...That is reasonable too..
Acutally, now fsck would bail out if if found some errors. For example
if we fail to check csum tree, it won't check fs root.
I don't have ideas that whether fsck should continue if error happen,
for example, logic error, enomem....
> same sort of checks and verification.
>
prev parent reply other threads:[~2014-06-03 3:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 9:59 [PATCH v2 1/4] Btrfs-progs: fsck: only allow partial opening under repair mode Wang Shilong
2014-05-29 9:59 ` [PATCH v2 3/4] Btrfs-progs: fsck: deal with corrupted csum root Wang Shilong
2014-06-02 17:27 ` David Sterba
2014-06-03 3:25 ` Wang Shilong
2014-06-03 16:21 ` David Sterba
2014-06-04 1:43 ` Wang Shilong
2014-06-02 16:18 ` [PATCH v2 1/4] Btrfs-progs: fsck: only allow partial opening under repair mode David Sterba
2014-06-03 3:35 ` Wang Shilong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538D4270.4030808@cn.fujitsu.com \
--to=wangsl.fnst@cn.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).