From: Anand Jain <Anand.Jain@oracle.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>, linux-btrfs@vger.kernel.org
Cc: dsterba@suse.cz, wangsl.fnst@cn.fujitsu.com, clm@fb.com, jbacik@fb.com
Subject: Re: [PATCH V3] Btrfs: device_list_add() should not update list when mounted
Date: Mon, 09 Jun 2014 11:29:06 +0800 [thread overview]
Message-ID: <53952A02.30705@oracle.com> (raw)
In-Reply-To: <53951D70.6040303@cn.fujitsu.com>
>> As mentioned in the other thread.. we expect user to check the devices
>> before / after mount and wipefs the disks which should not belong to
>> the fsid.
my bad. I just realized that unmount and wipefs may not be an
viable choice in case of btrfs as root fs.
> For the case you mentioned, I think the behavior is OK,
> always use the device with *current* largest generation is a acceptable
> strategy, since the only things we can depend on the devices we
> *current* see...
Yeah. let me do that approach as well to take care of picking
the correct disk when FS is _unmounted_.
And, when FS is mounted we should NOT kick out device paths
invariably. which means we still need the patch.
Btrfs: device_list_add() should not update list when mounted
Thanks, Anand
next prev parent reply other threads:[~2014-06-09 3:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 3:26 [PATCH V3] Btrfs: device_list_add() should not update list when mounted Anand Jain
2014-06-09 1:52 ` Qu Wenruo
2014-06-09 2:19 ` Anand Jain
2014-06-09 2:35 ` Qu Wenruo
2014-06-09 3:29 ` Anand Jain [this message]
2014-06-10 1:25 ` Qu Wenruo
2014-06-10 1:48 ` Anand Jain
2014-06-10 1:50 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53952A02.30705@oracle.com \
--to=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
--cc=wangsl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).