From: Josef Bacik <jbacik@fb.com>
To: Waiman Long <waiman.long@hp.com>, Marc Dionne <marc.c.dionne@gmail.com>
Cc: <linux-btrfs@vger.kernel.org>, <clm@fb.com>, <t-itoh@jp.fujitsu.com>
Subject: Re: Lockups with btrfs on 3.16-rc1 - bisected
Date: Wed, 18 Jun 2014 15:27:39 -0700 [thread overview]
Message-ID: <53A2125B.3050701@fb.com> (raw)
In-Reply-To: <53A20FFF.3010807@hp.com>
On 06/18/2014 03:17 PM, Waiman Long wrote:
> On 06/18/2014 04:57 PM, Marc Dionne wrote:
>> Hi,
>>
>> I've been seeing very reproducible soft lockups with 3.16-rc1 similar
>> to what is reported here:
>> https://urldefense.proofpoint.com/v1/url?u=http://marc.info/?l%3Dlinux-btrfs%26m%3D140290088532203%26w%3D2&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=cKCbChRKsMpTX8ybrSkonQ%3D%3D%0A&m=aoagvtZMwVb16gh1HApZZL00I7eP50GurBpuEo3l%2B5g%3D%0A&s=c62558feb60a480bbb52802093de8c97b5e1f23d4100265b6120c8065bd99565
>> , along with the
>> occasional hard lockup, making it impossible to complete a parallel
>> build on a btrfs filesystem for the package I work on. This was
>> working fine just a few days before rc1.
>>
>> Bisecting brought me to the following commit:
>>
>> commit bd01ec1a13f9a327950c8e3080096446c7804753
>> Author: Waiman Long<Waiman.Long@hp.com>
>> Date: Mon Feb 3 13:18:57 2014 +0100
>>
>> x86, locking/rwlocks: Enable qrwlocks on x86
>>
>> And sure enough if I revert that commit on top of current mainline,
>> I'm unable to reproduce the soft lockups and hangs.
>>
>> Marc
>
> The queue rwlock is fair. As a result, recursive read_lock is not
> allowed unless the task is in an interrupt context. Doing recursive
> read_lock will hang the process when a write_lock happens somewhere in
> between. Are recursive read_lock being done in the btrfs code?
>
We walk down a tree and read lock each node as we walk down, is that
what you mean? Or do you mean read_lock multiple times on the same lock
in the same process, cause we definitely don't do that. Thanks,
Josef
next prev parent reply other threads:[~2014-06-18 22:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-18 20:57 Lockups with btrfs on 3.16-rc1 - bisected Marc Dionne
2014-06-18 22:17 ` Waiman Long
2014-06-18 22:27 ` Josef Bacik [this message]
2014-06-18 22:47 ` Waiman Long
2014-06-18 23:10 ` Josef Bacik
2014-06-18 23:19 ` Waiman Long
2014-06-18 23:27 ` Chris Mason
2014-06-18 23:30 ` Waiman Long
2014-06-18 23:53 ` Chris Mason
2014-06-19 0:03 ` Marc Dionne
2014-06-19 0:08 ` Waiman Long
2014-06-19 0:41 ` Marc Dionne
2014-06-19 2:03 ` Marc Dionne
2014-06-19 2:11 ` Chris Mason
2014-06-19 3:21 ` Waiman Long
2014-06-19 16:51 ` Chris Mason
2014-06-19 17:52 ` Waiman Long
2014-06-19 20:10 ` Chris Mason
2014-06-19 21:50 ` Chris Mason
2014-06-19 23:21 ` Waiman Long
2014-06-20 3:20 ` Tsutomu Itoh
2014-06-21 1:09 ` Long, Wai Man
2014-06-19 9:49 ` btrfs-transacti:516 blocked 120 seconds on 3.16-rc1 Konstantinos Skarlatos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A2125B.3050701@fb.com \
--to=jbacik@fb.com \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=marc.c.dionne@gmail.com \
--cc=t-itoh@jp.fujitsu.com \
--cc=waiman.long@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).