From: Josef Bacik <jbacik@fb.com>
To: Mark Fasheh <mfasheh@suse.de>, <dsterba@suse.cz>,
<linux-btrfs@vger.kernel.org>, Chris Mason <clm@fb.com>
Subject: Re: btrfs: qgroup: account shared subtrees during snapshot delete
Date: Fri, 20 Jun 2014 08:44:51 -0700 [thread overview]
Message-ID: <53A456F3.4000500@fb.com> (raw)
In-Reply-To: <20140620152958.GR5484@wotan.suse.de>
On 06/20/2014 08:29 AM, Mark Fasheh wrote:
> On Fri, Jun 20, 2014 at 01:25:34PM +0200, David Sterba wrote:
>> On Thu, Jun 19, 2014 at 04:17:25PM -0700, Josef Bacik wrote:
>>>>> We don't pay attention to the return value, we should probably abort the
>>>>> transaction if there is a problem.
>>>>
>>>> Abort or log an error and continue? I ask because technically we could
>>>> continue with the subvolume drop but obviously qgroup state will need to be
>>>> fixed via a future rescan. I guess the question is which is more 'friendly'
>>>> to the user.
>>>
>>> I'd be ok with log an error and tell the user to rescan. Thanks,
>>
>> I agree.
>
> Great, I went ahead and did that. Below is patch #2 with all review comments
> implemented.
>
Looks good, you can add
Reviewed-by: Josef Bacik <jbacik@fb.com>
However I'd like to see an xfstest or two for this case so we're sure to be
testing everything properly. Once we have that we can merge it. Thanks,
Josef
next prev parent reply other threads:[~2014-06-20 15:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-19 21:49 [PATCH 0/2] btrfs: qgroup fixes for btrfs_drop_snapshot Mark Fasheh
2014-06-19 21:49 ` btrfs: add trace for qgroup accounting Mark Fasheh
2014-06-19 21:58 ` Josef Bacik
2014-06-19 21:49 ` btrfs: qgroup: account shared subtrees during snapshot delete Mark Fasheh
2014-06-19 22:25 ` Josef Bacik
2014-06-19 23:16 ` Mark Fasheh
2014-06-19 23:17 ` Josef Bacik
2014-06-20 11:25 ` David Sterba
2014-06-20 15:29 ` Mark Fasheh
2014-06-20 15:44 ` Josef Bacik [this message]
2014-06-20 17:18 ` Mark Fasheh
2014-06-23 14:49 ` David Sterba
-- strict thread matches above, loose matches on Subject: below --
2014-07-07 22:09 [PATCH 0/3] btrfs: qgroup fixes for btrfs_drop_snapshot V3 Mark Fasheh
2014-07-07 22:09 ` btrfs: qgroup: account shared subtrees during snapshot delete Mark Fasheh
2015-02-01 20:51 Dan Carpenter
2015-02-06 22:16 ` Mark Fasheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A456F3.4000500@fb.com \
--to=jbacik@fb.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=mfasheh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).