From: Josef Bacik <jbacik@fb.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Chris Mason <clm@fb.com>, Jiri Kosina <trivial@kernel.org>
Cc: <linux-btrfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if
Date: Fri, 20 Jun 2014 13:29:44 -0700 [thread overview]
Message-ID: <53A499B8.5050107@fb.com> (raw)
In-Reply-To: <1403293903-17696-1-git-send-email-linux@rasmusvillemoes.dk>
On 06/20/2014 12:51 PM, Rasmus Villemoes wrote:
> Maybe "else if" was meant, but because of the goto out_unlock, it
> doesn't make a difference. Anyway, I chose the "only whitespace" fix.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> fs/btrfs/tree-log.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> index 9e1f2cd..50af2b9 100644
> --- a/fs/btrfs/tree-log.c
> +++ b/fs/btrfs/tree-log.c
> @@ -3980,7 +3980,8 @@ again:
> if (ret < 0) {
> err = ret;
> goto out_unlock;
> - } if (ret) {
> + }
> + if (ret) {
> ins_nr = 0;
> btrfs_release_path(path);
> continue;
>
Nope that's right, thanks,
Reviewed-by: Josef Bacik <jbacik@fb.com>
next prev parent reply other threads:[~2014-06-20 20:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 19:51 [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if Rasmus Villemoes
2014-06-20 20:29 ` Josef Bacik [this message]
2014-08-22 20:05 ` Rasmus Villemoes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A499B8.5050107@fb.com \
--to=jbacik@fb.com \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).