* [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if
@ 2014-06-20 19:51 Rasmus Villemoes
2014-06-20 20:29 ` Josef Bacik
0 siblings, 1 reply; 3+ messages in thread
From: Rasmus Villemoes @ 2014-06-20 19:51 UTC (permalink / raw)
To: Chris Mason, Josef Bacik, Jiri Kosina
Cc: linux-btrfs, linux-kernel, Rasmus Villemoes
Maybe "else if" was meant, but because of the goto out_unlock, it
doesn't make a difference. Anyway, I chose the "only whitespace" fix.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
fs/btrfs/tree-log.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index 9e1f2cd..50af2b9 100644
--- a/fs/btrfs/tree-log.c
+++ b/fs/btrfs/tree-log.c
@@ -3980,7 +3980,8 @@ again:
if (ret < 0) {
err = ret;
goto out_unlock;
- } if (ret) {
+ }
+ if (ret) {
ins_nr = 0;
btrfs_release_path(path);
continue;
--
1.9.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if
2014-06-20 19:51 [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if Rasmus Villemoes
@ 2014-06-20 20:29 ` Josef Bacik
2014-08-22 20:05 ` Rasmus Villemoes
0 siblings, 1 reply; 3+ messages in thread
From: Josef Bacik @ 2014-06-20 20:29 UTC (permalink / raw)
To: Rasmus Villemoes, Chris Mason, Jiri Kosina; +Cc: linux-btrfs, linux-kernel
On 06/20/2014 12:51 PM, Rasmus Villemoes wrote:
> Maybe "else if" was meant, but because of the goto out_unlock, it
> doesn't make a difference. Anyway, I chose the "only whitespace" fix.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> fs/btrfs/tree-log.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
> index 9e1f2cd..50af2b9 100644
> --- a/fs/btrfs/tree-log.c
> +++ b/fs/btrfs/tree-log.c
> @@ -3980,7 +3980,8 @@ again:
> if (ret < 0) {
> err = ret;
> goto out_unlock;
> - } if (ret) {
> + }
> + if (ret) {
> ins_nr = 0;
> btrfs_release_path(path);
> continue;
>
Nope that's right, thanks,
Reviewed-by: Josef Bacik <jbacik@fb.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if
2014-06-20 20:29 ` Josef Bacik
@ 2014-08-22 20:05 ` Rasmus Villemoes
0 siblings, 0 replies; 3+ messages in thread
From: Rasmus Villemoes @ 2014-08-22 20:05 UTC (permalink / raw)
To: Josef Bacik; +Cc: Chris Mason, Jiri Kosina, linux-btrfs, linux-kernel
Josef Bacik <jbacik@fb.com> writes:
> On 06/20/2014 12:51 PM, Rasmus Villemoes wrote:
>> Maybe "else if" was meant, but because of the goto out_unlock, it
>> doesn't make a difference. Anyway, I chose the "only whitespace" fix.
>>
>> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>> ---
>> fs/btrfs/tree-log.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
>> index 9e1f2cd..50af2b9 100644
>> --- a/fs/btrfs/tree-log.c
>> +++ b/fs/btrfs/tree-log.c
>> @@ -3980,7 +3980,8 @@ again:
>> if (ret < 0) {
>> err = ret;
>> goto out_unlock;
>> - } if (ret) {
>> + }
>> + if (ret) {
>> ins_nr = 0;
>> btrfs_release_path(path);
>> continue;
>>
>
> Nope that's right, thanks,
>
> Reviewed-by: Josef Bacik <jbacik@fb.com>
Was this picked up? I don't see it upstream.
Thanks,
Rasmus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-22 20:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-20 19:51 [PATCH] trivial: fs/btrfs/tree-log.c: Fix closing brace followed by if Rasmus Villemoes
2014-06-20 20:29 ` Josef Bacik
2014-08-22 20:05 ` Rasmus Villemoes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).