From: Chris Mason <clm@fb.com>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: build failure with mason/for-linus tree
Date: Tue, 1 Jul 2014 10:30:18 -0400 [thread overview]
Message-ID: <53B2C5FA.1090808@fb.com> (raw)
In-Reply-To: <53B24A86.1050802@jp.fujitsu.com>
On 07/01/2014 01:43 AM, Satoru Takeuchi wrote:
> Hi Chris,
>
> FYI, today I failed to build mason/for-linus tree as follows.
>
You were building for 3.15?
> ===============================================================================
> ...
> /home/sat/src/linux-2.6/fs/btrfs/transaction.c: In function 'record_root_in_trans':
> /home/sat/src/linux-2.6/fs/btrfs/transaction.c:293:3: error: implicit declaration of function 'smp_mb__before_atomic' [-Werror=implicit-function-declaration]
> smp_mb__before_atomic();
> ^
> /home/sat/src/linux-2.6/fs/btrfs/transaction.c: In function 'commit_fs_roots':
> /home/sat/src/linux-2.6/fs/btrfs/transaction.c:1065:4: error: implicit declaration of function 'smp_mb__after_atomic' [-Werror=implicit-function-declaration]
> smp_mb__after_atomic();
> ^
> cc1: some warnings being treated as errors
> ...
> ===============================================================================
>
> It can be solved by cherry-picking febdbfe.
>
> ===
> commit febdbfe8a91ce0d11939d4940b592eb0dba8d663
> Author: Peter Zijlstra <peterz@infradead.org>
> Date: Thu Feb 6 18:16:07 2014 +0100
>
> arch: Prepare for smp_mb__{before,after}_atomic()
>
> Since the smp_mb__{before,after}*() ops are fundamentally dependent on
> how an arch can implement atomics it doesn't make sense to have 3
> variants of them. They must all be the same.
Yes, or revert:
commit c7548af69d9ef71512eb52d8009521eba3e768fd
Author: Chris Mason <clm@fb.com>
Date: Tue Jun 10 13:06:56 2014 -0700
Btrfs: convert smp_mb__{before,after}_clear_bit
The new call is smp_mb__{before,after}_atomic. The __ gives us extra
protection from the atomic rays.
Signed-off-by: Chris Mason <clm@fb.com>
Which is only needed on 3.16+
I should have put this one into a 3.16 only branch, it was a mistake on
my end.
-chris
next prev parent reply other threads:[~2014-07-01 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 5:43 build failure with mason/for-linus tree Satoru Takeuchi
2014-07-01 14:30 ` Chris Mason [this message]
2014-07-01 23:41 ` Satoru Takeuchi
2014-07-02 9:22 ` Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B2C5FA.1090808@fb.com \
--to=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=takeuchi_satoru@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).