From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: <dsterba@suse.cz>, Filipe David Borba Manana <fdmanana@gmail.com>,
<linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: atomically set inode->i_flags in btrfs_update_iflags
Date: Wed, 2 Jul 2014 09:25:58 +0900 [thread overview]
Message-ID: <53B35196.6040503@jp.fujitsu.com> (raw)
In-Reply-To: <20140701235657.GV1553@twin.jikos.cz>
(2014/07/02 8:56), David Sterba wrote:
> On Wed, Jun 25, 2014 at 10:36:02PM +0100, Filipe David Borba Manana wrote:
>> This change is based on the corresponding recent change for ext4:
>>
>> ext4: atomically set inode->i_flags in ext4_set_inode_flags()
>>
>> That has the following commit message that applies to btrfs as well:
>>
>> "Use cmpxchg() to atomically set i_flags instead of clearing out the
>> S_IMMUTABLE, S_APPEND, etc. flags and then setting them from the
>> EXT4_IMMUTABLE_FL, EXT4_APPEND_FL flags, since this opens up a race
>> where an immutable file has the immutable flag cleared for a brief
>> window of time."
>>
>> Replacing EXT4_IMMUTABLE_FL and EXT4_APPEND_FL with BTRFS_INODE_IMMUTABLE
>> and BTRFS_INODE_APPEND, respectively.
>>
>> Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
>
> Reviewed-by: David Sterba <dsterba@suse.cz>
Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-07-02 0:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 21:36 [PATCH] Btrfs: atomically set inode->i_flags in btrfs_update_iflags Filipe David Borba Manana
2014-07-01 23:56 ` David Sterba
2014-07-02 0:25 ` Satoru Takeuchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B35196.6040503@jp.fujitsu.com \
--to=takeuchi_satoru@jp.fujitsu.com \
--cc=dsterba@suse.cz \
--cc=fdmanana@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).