From: Wang Shilong <wangsl.fnst@cn.fujitsu.com>
To: Anand Jain <anand.jain@oracle.com>
Cc: <linux-btrfs@vger.kernel.org>, <quwenruo@cn.fujitsu.com>,
David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH 1/2 v3 RESEND] Btrfs: device_list_add() should not update list when mounted
Date: Wed, 2 Jul 2014 10:59:52 +0800 [thread overview]
Message-ID: <53B375A8.9000802@cn.fujitsu.com> (raw)
In-Reply-To: <53B2E27D.2030609@oracle.com>
On 07/02/2014 12:31 AM, Anand Jain wrote:
>
>
> Thanks for the commenting Wang.
> inline below.
>
>
> On 01/07/2014 15:16, Wang Shilong wrote:
>> Hi Anand,
>>
>> Sorry for delay reply, more comments below:
>>
>> On 06/13/2014 12:26 PM, Anand Jain wrote:
>>> From: Anand Jain <anand.jain@oracle.com>
>>>
[...]
>> I agree we don't allow to update device list when mounted, i tested this
>> patch, it worked but
>
> Thanks for testing this patch set.
>
>> it will output the following message:
>>
>> Scanning for Btrfs filesystems in '/dev/sdc'
>> ERROR: unable to scan the device '/dev/sdc' - Device or resource busy
>>
>> I think this is a little confusing for common users. Maybe don't return
>> error but output
>> some log message into kernel buffer, better?
>
>
> the Other choices are:
>
> display the error only when specific device is used
> by the user like 'btrfs dev scan /dev/sdc' And don't print busy /
> invalid error when a system wide scan is used like 'btrfs dev scan'.
> To achieve this we have to tweak btrfs-progs.
Maybe return EEXIST value here is better.
Also for your second patch, if we replace one disk with existed disk,
printk that info is good.:-)
Regard,
Wang
>
> or put the error under the verbose option in the btrfs-progs.
>
>
>
>
>> Thanks,
>> Wang
>>> name = rcu_string_strdup(path, GFP_NOFS);
>>> if (!name)
>>> return -ENOMEM;
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> .
>
prev parent reply other threads:[~2014-07-02 3:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 4:26 [PATCH 1/2 v3 RESEND] Btrfs: device_list_add() should not update list when mounted Anand Jain
2014-06-13 4:26 ` [PATCH 2/2] btrfs: check generation as replace duplicates devid+uuid Anand Jain
2014-07-01 7:39 ` Wang Shilong
2014-07-01 7:16 ` [PATCH 1/2 v3 RESEND] Btrfs: device_list_add() should not update list when mounted Wang Shilong
2014-07-01 16:31 ` Anand Jain
2014-07-02 2:59 ` Wang Shilong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B375A8.9000802@cn.fujitsu.com \
--to=wangsl.fnst@cn.fujitsu.com \
--cc=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).