From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: Anand Jain <anand.jain@oracle.com>, Chris Mason <clm@fb.com>
Cc: Miao Xie <miaox@cn.fujitsu.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: fix wrong uevent target
Date: Fri, 4 Jul 2014 09:58:41 +0800 [thread overview]
Message-ID: <53B60A51.5030101@cn.fujitsu.com> (raw)
In-Reply-To: <53B5939B.2050808@oracle.com>
-------- Original Message --------
Subject: Re: [PATCH] Btrfs: fix wrong uevent target
From: Anand Jain <anand.jain@oracle.com>
To: Chris Mason <clm@fb.com>
Date: 2014年07月04日 01:32
> Chris,
>
> This fix is theoretically correct but my guess that this would
> solve problem as reported by Qu Wenruo was wrong [1].
> Patch is good to integrate.
>
> Thanks, Anand
>
> [1] Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device
> add/remove.
Yes, whatever uevent improvement will not solve the problem of 'btrfs
dev scan; btrfs dev del; btrfs dev scan'.
Since uevent event is send from kernel and received by ueventd, then
ueventd goes to update the device file ctime/mtine.
The uevent procedure is always asynchronized, so it will not fix the
'btrfs dev scan' libblkid cache problem.
Althogh my RFC patch is ugly, it will provide a synchronzied method to
update ctime/mtime from kernel.
Thank,
Qu
>
>
> On 03/07/2014 22:00, Chris Mason wrote:
>> On 07/03/2014 07:09 AM, Miao Xie wrote:
>>> CC Anand Jain
>>>
>>> Sorry, please ignore this patch.
>>> Anand wrote the same patch several days ago, so this bug fix belongs
>>> to Anand
>>> though he NACKed his patch at that time.
>>
>> It certainly looks right, but Anand had mentioned that he had a few
>> questions on testing. I've pulled it out for now, but I'll take Anand's
>> version when you're both happy.
>>
>> -chris
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-07-04 1:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-02 9:03 [PATCH] Btrfs: fix wrong uevent target Miao Xie
2014-07-03 11:09 ` Miao Xie
2014-07-03 14:00 ` Chris Mason
2014-07-03 17:32 ` Anand Jain
2014-07-04 1:58 ` Qu Wenruo [this message]
2014-07-04 4:18 ` Miao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B60A51.5030101@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=anand.jain@oracle.com \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).