From: Eric Sandeen <sandeen@redhat.com>
To: dsterba@suse.cz, Qu Wenruo <quwenruo@cn.fujitsu.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command
Date: Mon, 07 Jul 2014 10:45:07 -0500 [thread overview]
Message-ID: <53BAC083.5020308@redhat.com> (raw)
In-Reply-To: <20140704135226.GO1553@twin.jikos.cz>
On 7/4/14, 8:52 AM, David Sterba wrote:
> On Fri, Jul 04, 2014 at 04:38:49PM +0800, Qu Wenruo wrote:
>> 'btrfs fi df' command is currently able to be executed on any file/dir
>> inside btrfs since it uses btrfs ioctl to get disk usage info.
>>
>> However it is somewhat confusing for some end users since normally such
>> command should only be executed on a mount point.
>
> I disagree here, it's much more convenient to run 'fi df' anywhere and
> get the output. The system 'df' command works the same way.
I agree with that, and said as much in the original bug filed @Fedora.
-Eric
prev parent reply other threads:[~2014-07-07 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 8:38 [PATCH 1/2] btrfs-progs: Check fstype in find_mount_root() Qu Wenruo
2014-07-04 8:38 ` [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command Qu Wenruo
2014-07-04 13:52 ` David Sterba
2014-07-04 22:04 ` Duncan
2014-07-07 0:44 ` Qu Wenruo
2014-07-22 14:41 ` David Sterba
2014-07-07 9:51 ` Vikram Goyal
2014-07-08 1:19 ` Qu Wenruo
2014-07-07 15:45 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BAC083.5020308@redhat.com \
--to=sandeen@redhat.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).