From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: Himangi Saraogi <himangi774@gmail.com>, Chris Mason <clm@fb.com>,
Josef Bacik <jbacik@fb.com>, <linux-btrfs@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <julia.lawall@lip6.fr>
Subject: Re: [PATCH] Btrfs: use BUG_ON
Date: Thu, 10 Jul 2014 09:05:09 +0900 [thread overview]
Message-ID: <53BDD8B5.2040609@jp.fujitsu.com> (raw)
In-Reply-To: <20140708222141.GA11854@himangi-Dell>
Hi Himangi,
(2014/07/09 7:21), Himangi Saraogi wrote:
> Use BUG_ON(x) rather than if(x) BUG();
>
> The semantic patch that fixes this problem is as follows:
>
> // <smpl>
> @@ identifier x; @@
> -if (x) BUG();
> +BUG_ON(x);
> // </smpl>
Strictly speaking, BUG_ON() is "if (unlikely(x)) BUG".
Anyway, I consider that put this condition in unlikely()
in this case is good.
BTW, there are many "if BUG()" case under fs/btrfs.
How about fix all of them?
===============================================================================
$ grep -rnH -B 1 "BUG()" fs/btrfs | grep -A 1 'if.*('
fs/btrfs/inode.c-6318- } else if (create && PageUptodate(page)) {
fs/btrfs/inode.c:6319: BUG();
--
fs/btrfs/volumes.c-2626- else if (ret)
fs/btrfs/volumes.c:2627: BUG(); # <- your patch fixes it.
--
fs/btrfs/volumes.c-3092- if (ret == 0)
fs/btrfs/volumes.c:3093: BUG(); /* FIXME break ? */
--
fs/btrfs/raid56.c-2048- if (rbio->faila == -1) {
fs/btrfs/raid56.c:2049: BUG();
===============================================================================
Thanks,
Satoru
>
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> fs/btrfs/volumes.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index 6104676..63e746e 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -2623,8 +2623,8 @@ again:
> found_key.offset);
> if (ret == -ENOSPC)
> failed++;
> - else if (ret)
> - BUG();
> + else
> + BUG_ON(ret);
> }
>
> if (found_key.offset == 0)
>
next prev parent reply other threads:[~2014-07-10 0:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-08 22:21 [PATCH] Btrfs: use BUG_ON Himangi Saraogi
2014-07-10 0:05 ` Satoru Takeuchi [this message]
2014-07-10 5:56 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BDD8B5.2040609@jp.fujitsu.com \
--to=takeuchi_satoru@jp.fujitsu.com \
--cc=clm@fb.com \
--cc=himangi774@gmail.com \
--cc=jbacik@fb.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).