From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
To: Filipe Manana <fdmanana@suse.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: set error return value in btrfs_get_blocks_direct
Date: Thu, 10 Jul 2014 11:30:42 +0900 [thread overview]
Message-ID: <53BDFAD2.3040204@jp.fujitsu.com> (raw)
In-Reply-To: <1404732921-15003-1-git-send-email-fdmanana@suse.com>
(2014/07/07 20:35), Filipe Manana wrote:
> We were returning with 0 (success) because we weren't extracting the
> error code from em (PTR_ERR(em)). Fix it.
>
> Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
> ---
> fs/btrfs/inode.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
> index 6b65fab..8a946c0 100644
> --- a/fs/btrfs/inode.c
> +++ b/fs/btrfs/inode.c
> @@ -6998,8 +6998,10 @@ static int btrfs_get_blocks_direct(struct inode *inode, sector_t iblock,
> block_start, len,
> orig_block_len,
> ram_bytes, type);
> - if (IS_ERR(em))
> + if (IS_ERR(em)) {
> + ret = PTR_ERR(em);
> goto unlock_err;
> + }
> }
>
> ret = btrfs_add_ordered_extent_dio(inode, start,
>
prev parent reply other threads:[~2014-07-10 2:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-07 11:35 [PATCH] Btrfs: set error return value in btrfs_get_blocks_direct Filipe Manana
2014-07-10 2:30 ` Satoru Takeuchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53BDFAD2.3040204@jp.fujitsu.com \
--to=takeuchi_satoru@jp.fujitsu.com \
--cc=fdmanana@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).