From: Josef Bacik <jbacik@fb.com>
To: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>,
Wang Shilong <wangsl.fnst@cn.fujitsu.com>,
Chris Mason <clm@fb.com>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
Kevin Brandstatter <icarusthecow@gmail.com>
Subject: Re: [BUG] "Quota Ignored On write" problem still exist with 3.16-rc5
Date: Wed, 23 Jul 2014 09:23:23 -0400 [thread overview]
Message-ID: <53CFB74B.8080607@fb.com> (raw)
In-Reply-To: <53CF077D.4000106@jp.fujitsu.com>
On 07/22/2014 08:53 PM, Satoru Takeuchi wrote:
> Hi Wang,
>
> (2014/07/18 19:29), Wang Shilong wrote:
>> On 07/18/2014 04:45 PM, Satoru Takeuchi wrote:
>>> Hi Josef, Chris,
>>>
>>> I found "Quota Ignored On write" problem still exist with 3.16-rc5,
>>> which Kevin reported before.
>>>
>>> Kevin's report:
>>> https://urldefense.proofpoint.com/v1/url?u=https://www.mail-archive.com/linux-btrfs%40vger.kernel.org/msg35292.html&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=cKCbChRKsMpTX8ybrSkonQ%3D%3D%0A&m=HiJFypfWVhg2Jy2US%2BNG1tF8q4%2BYUryNKec6yPkYJM4%3D%0A&s=9d1740f5e1701e4906fc04b77d9117052e84d6e16c30971b261d1acf41c10910
>>>
>>> The result of bisect:
>>> https://urldefense.proofpoint.com/v1/url?u=https://www.mail-archive.com/linux-btrfs%40vger.kernel.org/msg35304.html&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=cKCbChRKsMpTX8ybrSkonQ%3D%3D%0A&m=HiJFypfWVhg2Jy2US%2BNG1tF8q4%2BYUryNKec6yPkYJM4%3D%0A&s=75ca6ce24c6d8e64fccdb8f61e519c59b1c6d027140c4f0f5eac24942a53a55d
>> I guess this is because Josef's patch delayed qgroup accounting, it will
>> cause @refer and @excl updating very late...
>>
>> The patch maybe optimize to merge some delayed refs(for example), but
>> it updates qgroup accounting when commiting transaction which will be
>> very late,
>> we may have accumulated many data..
>
> Thank you for your comment. I know of the code logic which caused
> this problem. However, what I want to say here is that this
> problem should be fixed as soon as possible. It is a important
> regression problem and we've already know the root cause.
>
> If it's impossible to fix it by releasing 3.16, I consider this
> patch should be reverted.
>
That's not happening. Qgroups have always been broken in one way or
another, now with my stuff the accounting is always correct and we don't
have a huge performance impact with or without qgroups. We'll fix it
but there's no way we're reverting this work. Thanks,
Josef
next prev parent reply other threads:[~2014-07-23 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-18 8:45 [BUG] "Quota Ignored On write" problem still exist with 3.16-rc5 Satoru Takeuchi
2014-07-18 10:29 ` Wang Shilong
2014-07-23 0:53 ` Satoru Takeuchi
2014-07-23 1:54 ` Wang Shilong
2014-07-23 13:23 ` Josef Bacik [this message]
2014-07-24 22:51 ` Kevin Brandstatter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CFB74B.8080607@fb.com \
--to=jbacik@fb.com \
--cc=clm@fb.com \
--cc=icarusthecow@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=takeuchi_satoru@jp.fujitsu.com \
--cc=wangsl.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).