linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: fix build of static target
@ 2014-07-23 13:16 David Sterba
  2014-07-24  3:22 ` Satoru Takeuchi
  0 siblings, 1 reply; 2+ messages in thread
From: David Sterba @ 2014-07-23 13:16 UTC (permalink / raw)
  To: linux-btrfs; +Cc: David Sterba

A user repoted that static buid fails with

utils-lib.static.o: In function `arg_strtou64':
/home/dsterba/labs/btrfs-progs/utils-lib.c:17: multiple definition of `arg_strtou64'
utils-lib.static.o:/home/dsterba/labs/btrfs-progs/utils-lib.c:17: first defined here

utils-lib.o was mistakenly added to linker twice.

Signed-off-by: David Sterba <dsterba@suse.cz>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 8e14d4837520..3853b8734568 100644
--- a/Makefile
+++ b/Makefile
@@ -10,7 +10,7 @@ objects = ctree.o disk-io.o radix-tree.o extent-tree.o print-tree.o \
 	  root-tree.o dir-item.o file-item.o inode-item.o inode-map.o \
 	  extent-cache.o extent_io.o volumes.o utils.o repair.o \
 	  qgroup.o raid6.o free-space-cache.o list_sort.o props.o \
-	  utils-lib.o ulist.o qgroup-verify.o
+	  ulist.o qgroup-verify.o
 cmds_objects = cmds-subvolume.o cmds-filesystem.o cmds-device.o cmds-scrub.o \
 	       cmds-inspect.o cmds-balance.o cmds-send.o cmds-receive.o \
 	       cmds-quota.o cmds-qgroup.o cmds-replace.o cmds-check.o \
-- 
1.9.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs-progs: fix build of static target
  2014-07-23 13:16 [PATCH] btrfs-progs: fix build of static target David Sterba
@ 2014-07-24  3:22 ` Satoru Takeuchi
  0 siblings, 0 replies; 2+ messages in thread
From: Satoru Takeuchi @ 2014-07-24  3:22 UTC (permalink / raw)
  To: David Sterba, linux-btrfs

(2014/07/23 22:16), David Sterba wrote:
> A user repoted that static buid fails with
> 
> utils-lib.static.o: In function `arg_strtou64':
> /home/dsterba/labs/btrfs-progs/utils-lib.c:17: multiple definition of `arg_strtou64'
> utils-lib.static.o:/home/dsterba/labs/btrfs-progs/utils-lib.c:17: first defined here
> 
> utils-lib.o was mistakenly added to linker twice.
> 
> Signed-off-by: David Sterba <dsterba@suse.cz>

Reviewed-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>

> ---
>   Makefile | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 8e14d4837520..3853b8734568 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -10,7 +10,7 @@ objects = ctree.o disk-io.o radix-tree.o extent-tree.o print-tree.o \
>   	  root-tree.o dir-item.o file-item.o inode-item.o inode-map.o \
>   	  extent-cache.o extent_io.o volumes.o utils.o repair.o \
>   	  qgroup.o raid6.o free-space-cache.o list_sort.o props.o \
> -	  utils-lib.o ulist.o qgroup-verify.o
> +	  ulist.o qgroup-verify.o
>   cmds_objects = cmds-subvolume.o cmds-filesystem.o cmds-device.o cmds-scrub.o \
>   	       cmds-inspect.o cmds-balance.o cmds-send.o cmds-receive.o \
>   	       cmds-quota.o cmds-qgroup.o cmds-replace.o cmds-check.o \
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-07-24  3:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-23 13:16 [PATCH] btrfs-progs: fix build of static target David Sterba
2014-07-24  3:22 ` Satoru Takeuchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).