From: Chris Mason <clm@fb.com>
To: Eric Sandeen <sandeen@redhat.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH, RFC] btrfs: refactor open_ctree()
Date: Thu, 24 Jul 2014 17:25:07 -0400 [thread overview]
Message-ID: <53D179B3.6010800@fb.com> (raw)
In-Reply-To: <53AB6185.9060109@redhat.com>
On 06/25/2014 07:55 PM, Eric Sandeen wrote:
> First off: total RFC, don't merge this; it builds, but
> is totally untested.
>
> open_ctree() is almost 1000 lines long. I've started trying
> to refactor it, primarily into helper functions, and also
> simplifying (?) things a bit at the beginning by removing the
> ret = func(); if (ret) { err = ret; goto ... } dance where it's not
> needed.
>
> Does this look like a reasonable thing to do? Have I cut
> things into the right chunks? Would you rather see it as
> as series of patches, moving one hunk of code at a time?
I do love this patch, either as a series or one big patch. Whatever
makes it easiest for you to test is fine with me.
-chris
next prev parent reply other threads:[~2014-07-24 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-25 23:55 [PATCH, RFC] btrfs: refactor open_ctree() Eric Sandeen
2014-06-26 2:01 ` Qu Wenruo
2014-06-26 16:54 ` David Sterba
2014-07-24 21:25 ` Chris Mason [this message]
2014-07-24 22:38 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53D179B3.6010800@fb.com \
--to=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).