linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anand Jain <Anand.Jain@oracle.com>
To: Chris Mason <clm@fb.com>, Miao Xie <miaox@cn.fujitsu.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: integration tree updated
Date: Fri, 01 Aug 2014 17:05:35 +0800	[thread overview]
Message-ID: <53DB585F.8040400@oracle.com> (raw)
In-Reply-To: <53D1B595.7070908@fb.com>



Hi Chris,

  Looks like you missed Miao update (on 17 Jul) to back out the bad
  patch (below), and your integration branch (published on 25 Jul)
  still contains the same.

[PATCH 2/2] Btrfs: fix wrong total device counter after removing a seed 
device

  You should remove it.

  Simple test cases on your integration branch (like btrfs dev del OR
  btrfs/003) is failing due to this and I (+ others would) spend some
  time digging it out


Miao,

  If it helps -
     cur_devices in the loop is null.

BUG: unable to handle kernel NULL pointer dereference at 0000000000000050
IP: [<ffffffffa00a8fc0>] btrfs_rm_device+0x4c0/0x860 [btrfs]

         cur_devices = root->fs_info->fs_devices;
         do {
                 cur_devices->total_devices--;
                 cur_devices = cur_devices->seed;
         } while (device->fs_devices != cur_devices);


  PS: I didn't find the follow-up patch in the mailing list,
     did I missing anything ?

Thanks, Anand


On 07/25/2014 09:40 AM, Chris Mason wrote:
> Hi everyone,
>
> I've pushed out my current integration branch.  It does have a few of
> Miao Xie's patches missing because there were some rejects.  I think
> this was just because some things got pulled in out of order, and I'll
> get it fixed up.
>
> Also missing is Mark's quota snapshot deletion fixes.  They were
> crashing during btrfs/011 with CONFIG_DEBUG_PAGE_ALLOC on.  We'll get
> that nailed down.
>
> integration is subject to rebasing, so please treat it more like a patch
> queue.  It is very lightly tested, the goal is just to show which
> patches are already applied and which ones are still pending.
>
> Thanks!
>
> -chris
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

  parent reply	other threads:[~2014-08-01  9:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-25  1:40 integration tree updated Chris Mason
2014-07-25  2:16 ` Qu Wenruo
2014-07-25 11:47   ` Chris Mason
2014-08-01  9:05 ` Anand Jain [this message]
2014-08-05  1:17   ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DB585F.8040400@oracle.com \
    --to=anand.jain@oracle.com \
    --cc=clm@fb.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=miaox@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).