linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: dsterba@suse.cz, Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>,
	"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/3] btrfs-progs: random fixes of btrfs-filesystem documentation
Date: Tue, 19 Aug 2014 10:33:44 -0500	[thread overview]
Message-ID: <53F36E58.1090108@redhat.com> (raw)
In-Reply-To: <20140819151005.GX1553@twin.jikos.cz>

On 8/19/14, 10:10 AM, David Sterba wrote:
> On Mon, Aug 11, 2014 at 10:05:52AM -0700, Eric Sandeen wrote:
>> (What seems to be missing, though, is why would the user ever choose to use '-d?')
> 
> That's a fallback method if blkid or udev are not available. We've had
> reports in the past that this functionality should not be dropped.

Seems like using /proc/partitions would make more sense in that case
than a recursive scan of every file under /dev, wouldn't it?
Any details on those reports?

I'm just wondering when you might possibly have success looking deep
into the /dev tree if you didn't have success in /proc/partitions.

It looks like the functionality was added with:

commit 0dbd99fb3e117cd5f87eda492b6b4fab1b5bea23
Author: Goffredo Baroncelli <kreijack@inwind.it>
Date:   Wed Jun 15 21:55:25 2011 +0200

    Scan the devices listed in /proc/partitions
    
    During the commands:
        - btrfs filesystem show
        - btrfs device scan
    the devices "scanned" are extracted from /proc/partitions. This
    should avoid to scan devices not suitable for a btrfs filesystem like cdrom
    and floppy or to scan not existant devices.
    The old behavior (scan all the block devices under /dev) may be
    forced passing the "--all-devices" switch.

but I'm not sure why it was preserved.

It just seems a bit bizarre to have so many ways to get the same info.

Thanks,
-Eric


  reply	other threads:[~2014-08-19 15:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-11  9:11 [PATCH 1/3] btrfs-progs: random fixes of btrfs-filesystem documentation Satoru Takeuchi
2014-08-11 17:05 ` Eric Sandeen
2014-08-11 17:14   ` Eric Sandeen
2014-08-11 23:55     ` Satoru Takeuchi
2014-08-11 23:51   ` Satoru Takeuchi
2014-08-12  0:07     ` Eric Sandeen
2014-08-12  7:25       ` [PATCH 1/3 v2] " Satoru Takeuchi
2014-08-12  7:45         ` [PATCH 1/3 v3] " Satoru Takeuchi
2014-08-12  8:06           ` [PATCH 1/3 v4] " Satoru Takeuchi
2014-08-19 15:07             ` David Sterba
2014-08-19 15:10   ` [PATCH 1/3] " David Sterba
2014-08-19 15:33     ` Eric Sandeen [this message]
2014-08-20 13:22       ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F36E58.1090108@redhat.com \
    --to=sandeen@redhat.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=takeuchi_satoru@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).