From: Qu Wenruo <quwenruo@cn.fujitsu.com>
To: Chris Mason <clm@fb.com>, <linux-btrfs@vger.kernel.org>
Cc: David Sterba <dsterba@suse.cz>, Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH] btrfs: Don't continue mounting when superblock csum mismatches even generation is less than 10.
Date: Wed, 20 Aug 2014 10:34:53 +0800 [thread overview]
Message-ID: <53F4094D.2060606@cn.fujitsu.com> (raw)
In-Reply-To: <53F3A9F7.9070709@fb.com>
-------- Original Message --------
Subject: Re: [PATCH] btrfs: Don't continue mounting when superblock csum
mismatches even generation is less than 10.
From: Chris Mason <clm@fb.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>, <linux-btrfs@vger.kernel.org>
Date: 2014年08月20日 03:48
> On 08/06/2014 10:51 PM, Qu Wenruo wrote:
>> It seems that the patch is rejected in patchwork,
>>
>> Could any one tell me the reason?
> I had nack'd it because I was worried at the time about the super crc
> errors that Dave had found in the past. Sorry, I really thought I had
> sent email about it.
>
> But Dave has a great point in his reply about validating the super
> generation.
Thanks for the reason.
I'll search and look at Dave's mail and dig into it.
Although as mentioned in the reply to David,
the main problem is that I found two disk images with crazy values in
superblock and wrong csum,
but generation is still 4, and ignoring the csum error caused kernel BUG.
Thanks,
Qu
>
> -chris
next prev parent reply other threads:[~2014-08-20 2:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 8:49 [PATCH] btrfs: Don't continue mounting when superblock csum mismatches even generation is less than 10 Qu Wenruo
2014-08-07 2:51 ` Qu Wenruo
2014-08-19 17:18 ` David Sterba
2014-08-20 1:16 ` Qu Wenruo
2014-08-19 19:48 ` Chris Mason
2014-08-20 2:34 ` Qu Wenruo [this message]
2014-08-25 15:28 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4094D.2060606@cn.fujitsu.com \
--to=quwenruo@cn.fujitsu.com \
--cc=clm@fb.com \
--cc=dsterba@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).