linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: Anand Jain <Anand.Jain@oracle.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 0/3] btrfs-progs: remove full /dev scanning
Date: Thu, 21 Aug 2014 09:29:56 -0500	[thread overview]
Message-ID: <53F60264.5090401@redhat.com> (raw)
In-Reply-To: <53F5B18B.1030801@oracle.com>

On 8/21/14, 3:44 AM, Anand Jain wrote:
> 
> 
>  A long time back there was an attempt to remove it but
>  this avoided it. Pls ref to the link in this discussion.
> 
>  https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg27272.html

Hm, I guess I don't understand this.  How is udev related to whether
or not /proc/partitions is sufficient vs. recursive /dev?

To be clear, my patchset keeps the -d / --all-devices option.

It simply discovers all devices via /proc/partitions, not via
a full /dev tree walk.

Thanks,
-Eric


> Thanks, Anand
> 
> On 08/21/2014 06:21 AM, Eric Sandeen wrote:
>> btrfs fileystem show and btrfs device scan today both have
>> the "-d" option to scan everything under /dev.  But we also
>> have a mechanism to scan everything in /proc/partitions, which
>> should always be sufficient.
>>
>> If anyone knows why we'd find something deep under /dev but
>> not in /proc/partitions, speak now or forever hold your peace...
>>
>> Tested this by running through a matrix of -d, -m, or "" args
>> for show/scan, for a 2-device fs, with and without a symlinked
>> device, with and without a symlinked mountpoint.  All output was
>> identical.
>>
>> Thanks,
>> -Eric
>> -- 
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>


  reply	other threads:[~2014-08-21 14:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20 22:21 [PATCH 0/3] btrfs-progs: remove full /dev scanning Eric Sandeen
2014-08-20 22:22 ` [PATCH 1/3] btrfs-progs: scan /proc/partitions not all of /dev with "-d" Eric Sandeen
2014-08-26  8:27   ` Anand Jain
2014-08-20 22:23 ` [PATCH 2/3] btrfs-progs: don't fall back to recursive /dev scan Eric Sandeen
2014-08-26  8:27   ` Anand Jain
2014-08-20 22:24 ` [PATCH 3/3] btrfs-progs: remove BTRFS_SCAN_DEV and btrfs_scan_one_dir Eric Sandeen
2014-08-26  8:29   ` Anand Jain
2014-08-21  8:44 ` [PATCH 0/3] btrfs-progs: remove full /dev scanning Anand Jain
2014-08-21 14:29   ` Eric Sandeen [this message]
2014-08-26  8:24     ` Anand Jain
2014-08-26 11:08     ` David Sterba
2014-08-21 18:08 ` Goffredo Baroncelli
2014-08-26 10:55   ` David Sterba
2014-08-26 14:51     ` Eric Sandeen
2014-08-26 14:53       ` Chris Mason
2014-08-26 22:56         ` Anand Jain
2014-08-26  9:52 ` Anand Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53F60264.5090401@redhat.com \
    --to=sandeen@redhat.com \
    --cc=Anand.Jain@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).