From: Martin Steigerwald <Martin@lichtvoll.de>
To: Chris Mason <clm@fb.com>
Cc: Liu Bo <bo.li.liu@oracle.com>, linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH v3] Btrfs: fix task hang under heavy compressed write
Date: Tue, 26 Aug 2014 12:20:28 +0200 [thread overview]
Message-ID: <5413015.p5ELBzGdTR@merkaba> (raw)
In-Reply-To: <53FB4F05.6050801@fb.com>
Am Montag, 25. August 2014, 10:58:13 schrieb Chris Mason:
> On 08/15/2014 11:36 AM, Liu Bo wrote:
> > This has been reported and discussed for a long time, and this hang occurs
> > in both 3.15 and 3.16.
>
> [ great description ]
>
> I ran this through tests last week, and an overnight test over the
> weekend. It's in my for-linus branch now, along with everything else I
> plan on sending for rc3.
>
> Please double check my merge, I had to undo your rebase onto Miao's patches.
I would like to test this on 3.17-rc2, what do I need to do to make it apply
cleanly? That function in disk-io.c looks quite different from what the patch
assumes at the beginning, so I am not sure how to merge this.
martin@merkaba:~/Computer/Merkaba/Kernel/linux> patch -p1 < "../[PATCH v3]
Btrfs_fix task hang under heavy compressed write.mbox"
patching file fs/btrfs/async-thread.c
patching file fs/btrfs/async-thread.h
patching file fs/btrfs/delayed-inode.c
patching file fs/btrfs/disk-io.c
Hunk #2 FAILED at 713.
Hunk #3 succeeded at 827 (offset -29 lines).
1 out of 3 hunks FAILED -- saving rejects to file fs/btrfs/disk-io.c.rej
patching file fs/btrfs/extent-tree.c
patching file fs/btrfs/inode.c
Hunk #1 succeeded at 1096 (offset -15 lines).
Hunk #2 succeeded at 1883 (offset -43 lines).
Hunk #3 succeeded at 2825 (offset -47 lines).
Hunk #4 succeeded at 2835 (offset -47 lines).
Hunk #5 succeeded at 7166 (offset -345 lines).
Hunk #6 succeeded at 8504 (offset -371 lines).
patching file fs/btrfs/ordered-data.c
patching file fs/btrfs/qgroup.c
Hunk #1 succeeded at 2720 (offset -2 lines).
patching file fs/btrfs/raid56.c
patching file fs/btrfs/reada.c
patching file fs/btrfs/scrub.c
Hunk #1 succeeded at 428 (offset 1 line).
Hunk #2 succeeded at 999 (offset 2 lines).
Hunk #3 succeeded at 1616 (offset -8 lines).
Hunk #4 succeeded at 3204 (offset -29 lines).
patching file fs/btrfs/volumes.c
Hunk #1 succeeded at 5800 (offset -87 lines).
Otherwise, I´d wait till rc3, as my current 3.16.2 with v1 of this patch seems
to behave stable with trees occupying all space:
merkaba:~> btrfs fi sh /home
Label: 'home' uuid: […]
Total devices 2 FS bytes used 127.69GiB
devid 1 size 160.00GiB used 160.00GiB path /dev/dm-0
devid 2 size 160.00GiB used 160.00GiB path /dev/mapper/sata-home
Ciao,
--
Martin 'Helios' Steigerwald - http://www.Lichtvoll.de
GPG: 03B0 0D6C 0040 0710 4AFA B82F 991B EAAC A599 84C7
next prev parent reply other threads:[~2014-08-26 10:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-12 7:44 [PATCH] Btrfs: fix task hang under heavy compressed write Liu Bo
2014-08-12 14:35 ` [PATCH v2] " Liu Bo
2014-08-12 14:57 ` [PATCH] " Chris Mason
2014-08-13 0:53 ` Qu Wenruo
2014-08-13 11:54 ` Martin Steigerwald
2014-08-13 13:27 ` Rich Freeman
2014-08-13 15:20 ` Liu Bo
2014-08-14 9:27 ` Martin Steigerwald
2014-08-15 17:51 ` Martin Steigerwald
2014-08-15 15:36 ` [PATCH v3] " Liu Bo
2014-08-15 16:05 ` Chris Mason
2014-08-16 7:28 ` Miao Xie
2014-08-18 7:32 ` Liu Bo
2014-08-25 14:58 ` Chris Mason
2014-08-25 15:19 ` Liu Bo
2014-08-26 10:20 ` Martin Steigerwald [this message]
2014-08-26 10:38 ` Liu Bo
2014-08-26 12:04 ` Martin Steigerwald
2014-08-26 13:02 ` Chris Mason
2014-08-26 13:20 ` Martin Steigerwald
2014-08-31 11:48 ` Martin Steigerwald
2014-08-31 15:40 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5413015.p5ELBzGdTR@merkaba \
--to=martin@lichtvoll.de \
--cc=bo.li.liu@oracle.com \
--cc=clm@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).