From: Eric Sandeen <sandeen@redhat.com>
To: Chris Murphy <lists@colorremedies.com>,
Btrfs BTRFS <linux-btrfs@vger.kernel.org>
Cc: "dsterba@suse.cz Sterba" <dsterba@suse.cz>
Subject: Re: [bug] btrfs check --subvol-extents segfault
Date: Tue, 16 Sep 2014 16:34:59 -0500 [thread overview]
Message-ID: <5418AD03.4090301@redhat.com> (raw)
In-Reply-To: <BB091951-5382-4788-901D-20E96546548A@colorremedies.com>
On 9/16/14 4:33 PM, Chris Murphy wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1142421
>
> kernel-3.17.0-0.rc5.git0.1.fc22.x86_64
> btrfs-progs-3.16-1.fc21.x86_64
>
> Steps to Reproduce:
> 1. mkfs.btrfs /dev/sdc
> 2. btrfs check --subvol-extents /dev/sdc
>
> Results:
> Segmentation fault (core dumped)
>
> [ 632.749774] btrfs[692]: segfault at 0 ip 00007fc9963fdd77 sp 00007fff93450880 error 4 in libc-2.19.90.so[7fc9963c2000+1bd000]
>
> Eric Sandeed writes in the bugzilla that this was broken by commit
> d34cbe76c723a05a14bbcfdc46e8ede789c3f1f9 which drops the requirement
> to specify a subvolid, but still does arg_strtou64(optarg) ->
> arg_strtou64(NULL) so it crashes.
Yeah, AFAICT (although it's not documented anywhere) the functionality is
*supposed* to take a subvolid as an argument.
The commit lets it pass w/ no args, but still does arg_strtou64(optarg) to get
the subvolid, and boom.
I think the commit just needs to be reverted, and then manpages updated &
testcases written...
-Eric
next prev parent reply other threads:[~2014-09-16 21:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 21:33 [bug] btrfs check --subvol-extents segfault Chris Murphy
2014-09-16 21:34 ` Eric Sandeen [this message]
2014-09-29 3:20 ` Qu Wenruo
2014-10-24 3:03 ` Zygo Blaxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5418AD03.4090301@redhat.com \
--to=sandeen@redhat.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=lists@colorremedies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).