* [bug] btrfs check --subvol-extents segfault @ 2014-09-16 21:33 Chris Murphy 2014-09-16 21:34 ` Eric Sandeen 0 siblings, 1 reply; 4+ messages in thread From: Chris Murphy @ 2014-09-16 21:33 UTC (permalink / raw) To: Btrfs BTRFS; +Cc: dsterba@suse.cz Sterba https://bugzilla.redhat.com/show_bug.cgi?id=1142421 kernel-3.17.0-0.rc5.git0.1.fc22.x86_64 btrfs-progs-3.16-1.fc21.x86_64 Steps to Reproduce: 1. mkfs.btrfs /dev/sdc 2. btrfs check --subvol-extents /dev/sdc Results: Segmentation fault (core dumped) [ 632.749774] btrfs[692]: segfault at 0 ip 00007fc9963fdd77 sp 00007fff93450880 error 4 in libc-2.19.90.so[7fc9963c2000+1bd000] Eric Sandeed writes in the bugzilla that this was broken by commit d34cbe76c723a05a14bbcfdc46e8ede789c3f1f9 which drops the requirement to specify a subvolid, but still does arg_strtou64(optarg) -> arg_strtou64(NULL) so it crashes. Chris Murphy ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [bug] btrfs check --subvol-extents segfault 2014-09-16 21:33 [bug] btrfs check --subvol-extents segfault Chris Murphy @ 2014-09-16 21:34 ` Eric Sandeen 2014-09-29 3:20 ` Qu Wenruo 0 siblings, 1 reply; 4+ messages in thread From: Eric Sandeen @ 2014-09-16 21:34 UTC (permalink / raw) To: Chris Murphy, Btrfs BTRFS; +Cc: dsterba@suse.cz Sterba On 9/16/14 4:33 PM, Chris Murphy wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1142421 > > kernel-3.17.0-0.rc5.git0.1.fc22.x86_64 > btrfs-progs-3.16-1.fc21.x86_64 > > Steps to Reproduce: > 1. mkfs.btrfs /dev/sdc > 2. btrfs check --subvol-extents /dev/sdc > > Results: > Segmentation fault (core dumped) > > [ 632.749774] btrfs[692]: segfault at 0 ip 00007fc9963fdd77 sp 00007fff93450880 error 4 in libc-2.19.90.so[7fc9963c2000+1bd000] > > Eric Sandeed writes in the bugzilla that this was broken by commit > d34cbe76c723a05a14bbcfdc46e8ede789c3f1f9 which drops the requirement > to specify a subvolid, but still does arg_strtou64(optarg) -> > arg_strtou64(NULL) so it crashes. Yeah, AFAICT (although it's not documented anywhere) the functionality is *supposed* to take a subvolid as an argument. The commit lets it pass w/ no args, but still does arg_strtou64(optarg) to get the subvolid, and boom. I think the commit just needs to be reverted, and then manpages updated & testcases written... -Eric ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [bug] btrfs check --subvol-extents segfault 2014-09-16 21:34 ` Eric Sandeen @ 2014-09-29 3:20 ` Qu Wenruo 2014-10-24 3:03 ` Zygo Blaxell 0 siblings, 1 reply; 4+ messages in thread From: Qu Wenruo @ 2014-09-29 3:20 UTC (permalink / raw) To: Eric Sandeen, Chris Murphy, Btrfs BTRFS; +Cc: dsterba@suse.cz Sterba Ping. No response? Thanks, Qu -------- Original Message -------- Subject: Re: [bug] btrfs check --subvol-extents segfault From: Eric Sandeen <sandeen@redhat.com> To: Chris Murphy <lists@colorremedies.com>, Btrfs BTRFS <linux-btrfs@vger.kernel.org> Date: 2014年09月17日 05:34 > On 9/16/14 4:33 PM, Chris Murphy wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=1142421 >> >> kernel-3.17.0-0.rc5.git0.1.fc22.x86_64 >> btrfs-progs-3.16-1.fc21.x86_64 >> >> Steps to Reproduce: >> 1. mkfs.btrfs /dev/sdc >> 2. btrfs check --subvol-extents /dev/sdc >> >> Results: >> Segmentation fault (core dumped) >> >> [ 632.749774] btrfs[692]: segfault at 0 ip 00007fc9963fdd77 sp 00007fff93450880 error 4 in libc-2.19.90.so[7fc9963c2000+1bd000] >> >> Eric Sandeed writes in the bugzilla that this was broken by commit >> d34cbe76c723a05a14bbcfdc46e8ede789c3f1f9 which drops the requirement >> to specify a subvolid, but still does arg_strtou64(optarg) -> >> arg_strtou64(NULL) so it crashes. > Yeah, AFAICT (although it's not documented anywhere) the functionality is > *supposed* to take a subvolid as an argument. > > The commit lets it pass w/ no args, but still does arg_strtou64(optarg) to get > the subvolid, and boom. > > I think the commit just needs to be reverted, and then manpages updated & > testcases written... > > -Eric > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [bug] btrfs check --subvol-extents segfault 2014-09-29 3:20 ` Qu Wenruo @ 2014-10-24 3:03 ` Zygo Blaxell 0 siblings, 0 replies; 4+ messages in thread From: Zygo Blaxell @ 2014-10-24 3:03 UTC (permalink / raw) To: Qu Wenruo; +Cc: Eric Sandeen, Chris Murphy, Btrfs BTRFS, dsterba@suse.cz Sterba [-- Attachment #1: Type: text/plain, Size: 1998 bytes --] I just stumbled across this bug a few hours ago. It's still in btrfs-progs 3.17. On Mon, Sep 29, 2014 at 11:20:06AM +0800, Qu Wenruo wrote: > Ping. > > No response? > > Thanks, > Qu > -------- Original Message -------- > Subject: Re: [bug] btrfs check --subvol-extents segfault > From: Eric Sandeen <sandeen@redhat.com> > To: Chris Murphy <lists@colorremedies.com>, Btrfs BTRFS > <linux-btrfs@vger.kernel.org> > Date: 2014年09月17日 05:34 > >On 9/16/14 4:33 PM, Chris Murphy wrote: > >>https://bugzilla.redhat.com/show_bug.cgi?id=1142421 > >> > >>kernel-3.17.0-0.rc5.git0.1.fc22.x86_64 > >>btrfs-progs-3.16-1.fc21.x86_64 > >> > >>Steps to Reproduce: > >>1. mkfs.btrfs /dev/sdc > >>2. btrfs check --subvol-extents /dev/sdc > >> > >>Results: > >>Segmentation fault (core dumped) > >> > >>[ 632.749774] btrfs[692]: segfault at 0 ip 00007fc9963fdd77 sp 00007fff93450880 error 4 in libc-2.19.90.so[7fc9963c2000+1bd000] > >> > >>Eric Sandeed writes in the bugzilla that this was broken by commit > >>d34cbe76c723a05a14bbcfdc46e8ede789c3f1f9 which drops the requirement > >>to specify a subvolid, but still does arg_strtou64(optarg) -> > >>arg_strtou64(NULL) so it crashes. > >Yeah, AFAICT (although it's not documented anywhere) the functionality is > >*supposed* to take a subvolid as an argument. > > > >The commit lets it pass w/ no args, but still does arg_strtou64(optarg) to get > >the subvolid, and boom. > > > >I think the commit just needs to be reverted, and then manpages updated & > >testcases written... > > > >-Eric > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 198 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-24 3:03 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-09-16 21:33 [bug] btrfs check --subvol-extents segfault Chris Murphy 2014-09-16 21:34 ` Eric Sandeen 2014-09-29 3:20 ` Qu Wenruo 2014-10-24 3:03 ` Zygo Blaxell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).