Re: "Btrfs: device_list_add() should not update list when mounted" breaks subvol mount

[Anand Jain <Anand.Jain@oracle.com>]

Johannes, Xavier,

  Can you pls send the output for ..

    cat /etc/fstab  | egrep btrfs
    cat /proc/self/mounts | egrep btrfs
    mount | egrep btrfs

Thanks, Anand


On 16/09/2014 06:17, Johannes Hirte wrote:
> On Tue, 16 Sep 2014 01:39:49 +0800
> Anand Jain <Anand.Jain@oracle.com> wrote:
>
>>
>>
>> On 16/09/2014 01:14, Johannes Hirte wrote:
>>> On Mon, 15 Sep 2014 20:32:58 +0800
>>> Anand Jain <Anand.Jain@oracle.com> wrote:
>>>
>>>>
>>>>
>>>> Hi Johannes,
>>>>
>>>>     Can I have you this tested.. ? Thanks.
>>>>
>>>>
>>>> -------
>>>> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
>>>> index e9676a4..1224b61 100644
>>>> --- a/fs/btrfs/volumes.c
>>>> +++ b/fs/btrfs/volumes.c
>>>> @@ -533,7 +533,7 @@ static noinline int device_list_add(const char
>>>> *path,
>>>>                     * the btrfs dev scan cli, after FS has been
>>>> mounted. */
>>>>                    if (fs_devices->opened) {
>>>> -                       return -EBUSY;
>>>> +                       goto out;
>>>>                    } else {
>>>>                            /*
>>>>                             * That is if the FS is _not_ mounted
>>>> and if you @@ -566,6 +566,7 @@ static noinline int
>>>> device_list_add(const char *path, if (!fs_devices->opened)
>>>>                    device->generation = found_transid;
>>>>
>>>> +out:
>>>>            *fs_devices_ret = fs_devices;
>>>>
>>>>            return ret;
>>>> -------
>>>
>>> With this change, it works again without initramfs.
>>
>>    Thanks. I am bit confused, is there any configuration that is
>>    still not working, even with the above changes.
>>
>> Anand
>
> At moment, I'm not aware of any. But I will test the remaining systems
> I have.
>
> regards,
>    Johannes
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>