From: Josef Bacik <jbacik@fb.com>
To: Liu Bo <bo.li.liu@oracle.com>, <xfs@oss.sgi.com>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] xfstests: remove check_scratch_fs in btrfs/012
Date: Fri, 19 Sep 2014 11:02:38 -0400 [thread overview]
Message-ID: <541C458E.3080406@fb.com> (raw)
In-Reply-To: <1409714759-9805-1-git-send-email-bo.li.liu@oracle.com>
On 09/02/2014 11:25 PM, Liu Bo wrote:
> From: Liu Bo <liub.liubo@gmail.com>
>
> btrfs/012 is a case to verify btrfs-convert feature, it converts an ext4 to
> btrfs firstly and do something, then rolls back to ext4.
>
> So at last we have a ext4 on the scratch device, but setting _require_scratch
> will force a btrfsck on a ext4 fs because $FSTYP here is btrfs, and it ends up
> with a failure report of _check_btrfs_filesystem.
>
> Now that we have deliberately check the final ext4 fs in btrfs/012, just do not
> set _require_scratch in this case.
>
> Signed-off-by: Liu Bo <liub.liubo@gmail.com>
I sent a patch for this already, it's on the fs-tests list. Thanks,
Josef
prev parent reply other threads:[~2014-09-19 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 3:25 [PATCH] xfstests: remove check_scratch_fs in btrfs/012 Liu Bo
2014-09-19 6:37 ` Eryu Guan
2014-09-19 15:02 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541C458E.3080406@fb.com \
--to=jbacik@fb.com \
--cc=bo.li.liu@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).