From: Josef Bacik <jbacik@fb.com>
To: Mitch Harder <mitch.harder@sabayonlinux.org>
Cc: linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs-progs: make fsck deal with bogus items
Date: Fri, 3 Oct 2014 11:47:12 -0400 [thread overview]
Message-ID: <542EC500.8020805@fb.com> (raw)
In-Reply-To: <CAKcLGm-1Qy7uh6sFPQKD7r5qvc=NiK=KhieV+Zay-uT-Z3n23A@mail.gmail.com>
On 10/03/2014 11:46 AM, Mitch Harder wrote:
> On Fri, Oct 3, 2014 at 9:54 AM, Josef Bacik <jbacik@fb.com> wrote:
>> We can deal with corrupt items by deleting them in a few cases. Fsck can easily
>> recover from a missing extent item or a dir index item. So if we notice a item
>> is completely bogus and it is of a key that we know we can repair then just
>> delete it and carry on. Thanks,
>>
>> Signed-off-by: Josef Bacik <jbacik@fb.com>
>> ---
>> cmds-check.c | 45 +++++++++++++++++++++++++++++++
>> tests/fsck-tests/005-bad-item-offset.img | Bin 0 -> 398336 bytes
>> 2 files changed, 45 insertions(+)
>> create mode 100644 tests/fsck-tests/005-bad-item-offset.img
>>
>
> It looks like tests/fsck-tests/005-bad-item-offset.img was added
> unintentionally to this patch.
>
Nope I meant to do that, its a testcase for the patch. Thanks,
Josef
prev parent reply other threads:[~2014-10-03 15:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 14:54 [PATCH] Btrfs-progs: make fsck deal with bogus items Josef Bacik
2014-10-03 15:46 ` Mitch Harder
2014-10-03 15:47 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542EC500.8020805@fb.com \
--to=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=mitch.harder@sabayonlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).