From: Anand Jain <Anand.Jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2] btrfs-progs: force overwrite should wipe stale SB
Date: Fri, 10 Oct 2014 15:47:52 +0800 [thread overview]
Message-ID: <54378F28.5090300@oracle.com> (raw)
In-Reply-To: <20141010073949.GE22943@twin.jikos.cz>
Thanks.
Anand
On 10/10/2014 03:39 PM, David Sterba wrote:
> On Thu, Oct 02, 2014 at 07:22:09AM +0800, Anand Jain wrote:
>> (I am unable to reproduce the issue, tried to go back with progs versions
>> but still the same. So as of now this code remains untested, suggest to
>> wait till we have a reproducible test case).
>>
>> Here is a test case which says it all..
>>
>> mkfs.xfs -f $DEV
>> mkfs.btrfs -f $DEV
>> mount $DEV $MNT
>> mount: /dev/vdiskc: more filesystems detected. This should not happen,
>> use -t <type> to explicitly specify the filesystem type or
>> use wipefs(8) to clean up the device.
>>
>> mount: you must specify the filesystem type
>>
>> with this patch btrfs_prepare_device() also wipes old FS if any,
>> btrfs_prepare_device() is called after we have verified that
>> user has provided -f option.
>>
>> v2: to satisfy the backward compatibility issue, replace
>> blkid_do_wipe() with local wipe function.
>
> Thank you, works for me, added to 3.17 queue.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-10-10 7:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 15:51 [PATCH] btrfs-progs: force overwrite should wipe stale SB Anand Jain
2014-09-15 16:15 ` David Sterba
2014-10-01 11:26 ` David Sterba
2014-10-01 11:45 ` Anand Jain
2014-10-01 23:22 ` [PATCH v2] " Anand Jain
2014-10-10 7:39 ` David Sterba
2014-10-10 7:47 ` Anand Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54378F28.5090300@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).