From: Miao Xie <miaox@cn.fujitsu.com>
To: Josef Bacik <jbacik@fb.com>, <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] Btrfs: don't do async reclaim during log replay V2
Date: Fri, 7 Nov 2014 09:18:55 +0800 [thread overview]
Message-ID: <545C1DFF.2070403@cn.fujitsu.com> (raw)
In-Reply-To: <545B8817.2040107@fb.com>
On Thu, 6 Nov 2014 09:39:19 -0500, Josef Bacik wrote:
> On 10/23/2014 04:44 AM, Miao Xie wrote:
>> On Thu, 18 Sep 2014 11:27:17 -0400, Josef Bacik wrote:
>>> Trying to reproduce a log enospc bug I hit a panic in the async reclaim code
>>> during log replay. This is because we use fs_info->fs_root as our root for
>>> shrinking and such. Technically we can use whatever root we want, but let's
>>> just not allow async reclaim while we're doing log replay. Thanks,
>>
>> Why not move the code of fs_root initialization to the front of log replay?
>> I think it is better than the fix way in this patch because the async reclaimer
>> can help us do some work.
>>
>
> Because this is simpler. We could move the initialization forward, but then say somebody comes and adds some other dependency to the async reclaim stuff in the future and doesn't think about log replay and suddenly some poor sap's box panics on mount. Log replay is a known quantity, we don't have to worry about enospc, so lets make it as simple as possible. Thanks,
Yes, you are right.
So this patch looks good.
Reviewed-by: Miao Xie <miaox@cn.fujitsu.com>
prev parent reply other threads:[~2014-11-07 1:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 15:27 [PATCH] Btrfs: don't do async reclaim during log replay V2 Josef Bacik
2014-10-23 8:44 ` Miao Xie
2014-10-29 9:10 ` Miao Xie
2014-11-06 14:39 ` Josef Bacik
2014-11-07 1:18 ` Miao Xie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545C1DFF.2070403@cn.fujitsu.com \
--to=miaox@cn.fujitsu.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).