Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Marcos Paulo de Souza <marcos@mpdesouza.com>
To: Neal Gompa <ngompa13@gmail.com>
Cc: David Sterba <dsterba@suse.com>,
	Btrfs BTRFS <linux-btrfs@vger.kernel.org>,
	Marcos Paulo de Souza <mpdesouza@suse.com>
Subject: Re: [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option
Date: Mon, 03 Aug 2020 23:57:54 -0300	[thread overview]
Message-ID: <5470b51ec2da3bda36c6390f5de939dc6c43dc89.camel@mpdesouza.com> (raw)
In-Reply-To: <CAEg-Je8VCXVC=9z-cCtszKxKeVbRMUojEQzHAuYkgdv4jXm-oQ@mail.gmail.com>

On Mon, 2020-08-03 at 21:24 -0400, Neal Gompa wrote:
> On Mon, Aug 3, 2020 at 1:05 AM Marcos Paulo de Souza
> <marcos@mpdesouza.com> wrote:
> >
> > From: Marcos Paulo de Souza <mpdesouza@suse.com>
> >
> > Since it's inclusion in b3751c131 ("btrfs-progs: docs: update
> > btrfs-man5"), this option was never available in kernel, we can
> only
> > enable this option using usebackuproot.
> >
> > Signed-off-by: Marcos Paulo de Souza <mpdesouza@suse.com>
> > ---
> >  Documentation/btrfs-man5.asciidoc | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/btrfs-man5.asciidoc
> b/Documentation/btrfs-man5.asciidoc
> > index 064312ed..2edf721c 100644
> > --- a/Documentation/btrfs-man5.asciidoc
> > +++ b/Documentation/btrfs-man5.asciidoc
> > @@ -471,7 +471,6 @@ The tree log could contain new
> files/directories, these would not exist on
> >  a mounted filesystem if the log is not replayed.
> >
> >  *usebackuproot*::
> > -*nousebackuproot*::
> >  (since: 4.6, default: off)
> >  +
> >  Enable autorecovery attempts if a bad tree root is found at mount
> time.
> > --
> > 2.27.0
> >
> 
> Shouldn't this option be plumbed through instead?

As this option is only used at mount time, I don't see why we should be
able to disable using remount for example. Am I missing something?

Thanks,
  Marcos


  reply	other threads:[~2020-08-04  2:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03  4:29 [PATCH btrfs-progs] Documentation: btrfs-man5: Remove nonexistent nousebackuproot option Marcos Paulo de Souza
2020-08-04  1:24 ` Neal Gompa
2020-08-04  2:57   ` Marcos Paulo de Souza [this message]
2020-08-04  7:51     ` Nikolay Borisov
2020-08-04  8:12 ` Nikolay Borisov
2020-08-04 11:31 ` Neal Gompa
2020-08-11  6:52 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5470b51ec2da3bda36c6390f5de939dc6c43dc89.camel@mpdesouza.com \
    --to=marcos@mpdesouza.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=mpdesouza@suse.com \
    --cc=ngompa13@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox