linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert White <rwhite@pobox.com>
To: Roman Mamedov <rm@romanrm.net>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Can't cp --reflink files on a Ext4-converted FS w/o checksums
Date: Wed, 26 Nov 2014 16:45:43 -0800	[thread overview]
Message-ID: <54767437.6020807@pobox.com> (raw)
In-Reply-To: <20141127052826.04bb45f5@natsu>

On 11/26/2014 04:28 PM, Roman Mamedov wrote:
> On Wed, 26 Nov 2014 16:20:44 -0800
> Robert White <rwhite@pobox.com> wrote:
>> (Trying to clear the NOCOW attribute on a file in BTRFS is _silently_
>> ignored as invalid. That recursive removal only changed the directories.)
>
> And the chattr command even completes with a zero exit code, this is rather
> unexpected.

That's what "silently" means in this context. I didn't pick the result, 
and it's not what I would have done. I've got no idea if this was ever 
discussed at any length for pros-and-cons. I could make an argument for 
the silent result, or against it. Since the attribute is immutable there 
really isn't a "nope, that's just not possible dave" errno value to 
return that isn't as confusing as just skipping it.

The closest result code would be ENOSUP (operation not supported) but 
changing attributes _is_ supported, just not that particular attribute 
in that particular circumstance.

Also, the "set attributes" call sets all the attributes at once so there 
is no way to say which attribute was rejected. As such, a "do what you 
can and let the people check the result" behavior is not at all 
unreasonable.

Life is full of flaws. 8-)


  reply	other threads:[~2014-11-27  0:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 19:55 Can't cp --reflink files on a Ext4-converted FS w/o checksums Roman Mamedov
2014-11-26 23:18 ` Robert White
2014-11-26 23:33   ` Roman Mamedov
2014-11-27  0:00     ` Robert White
2014-11-27  0:20       ` Roman Mamedov
2014-11-27  0:31         ` Robert White
2014-11-27  0:57           ` Robert White
2014-11-27  0:20     ` Robert White
2014-11-27  0:28       ` Roman Mamedov
2014-11-27  0:45         ` Robert White [this message]
2014-11-27  9:27   ` Duncan
2014-11-28  7:12     ` Robert White
2014-11-27  3:31 ` Liu Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54767437.6020807@pobox.com \
    --to=rwhite@pobox.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=rm@romanrm.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).