From: Anand Jain <anand.jain@oracle.com>
To: Goffredo Baroncelli <kreijack@gmail.com>
Cc: linux-btrfs@vger.kernel.org, David Sterba <dsterba@suse.cz>
Subject: Re: [PATCH V2][BTRFS-PROGS] Improve output of mkfs.btrfs command
Date: Thu, 18 Dec 2014 10:28:04 +0800 [thread overview]
Message-ID: <54923BB4.9030500@oracle.com> (raw)
In-Reply-To: <1418847252-14184-1-git-send-email-kreijack@inwind.it>
This is nice !
Can I suggest you to take care of 'btrfs fi show' output as well :-)
it needs a similar revamp.
Earlier I tried to add group profile into the show output but that broke
xfstest cases depending on it. so just a note.
Thanks, Anand
On 18/12/2014 04:14, Goffredo Baroncelli wrote:
> Hi All,
>
> enclosed a patches set to improve the output of mkfs.btrfs command.
>
> Currently I find the output of mkfs.btrfs command quite confusing:
>
> -- cut -- cut --
> # mkfs.btrfs -f -M -d raid5 -m raid5 /dev/vd[b-k]
>
> Btrfs v3.17
> See http://btrfs.wiki.kernel.org for more information.
>
> Turning ON incompat feature 'mixed-bg': mixed data and metadata block groups
> Turning ON incompat feature 'extref': increased hardlink limit per file to 65536
> Turning ON incompat feature 'raid56': raid56 extended format
> Created a data/metadata chunk of size 8388608
> adding device /dev/vdc id 2
> adding device /dev/vdd id 3
> adding device /dev/vde id 4
> adding device /dev/vdf id 5
> adding device /dev/vdg id 6
> adding device /dev/vdh id 7
> adding device /dev/vdi id 8
> adding device /dev/vdj id 9
> adding device /dev/vdk id 10
> fs created label (null) on /dev/vdb
> nodesize 4096 leafsize 4096 sectorsize 4096 size 356.01GiB
> -- cut -- cut --
>
> After my patches the output becomes:
> -- cut -- cut --
>
> # mkfs.btrfs -L btrfs-test -f -M -m raid5 -d raid5 /dev/vd[b-k]"
> BTRFS filesystem summary:
> Label: btrfs-test
> UUID: 4409e381-f066-4e7b-af74-b6525fefa08b
>
> Node size: 4096
> Leaf size: 4096
> Sector size: 4096
> Initial chunks:
> Data+Metadata: 9.01GiB
> System: 18.06MiB
> Metadata profile: RAID5
> Data profile: RAID5
> Mixed mode: YES
> SSD detected: NO
> Incompat features: mixed-bg, extref, raid56
> Number of devices: 10
> UUID ID SIZE PATH
> ------------------------------------ -- --------- -----------
> 907a3722-5d3e-4ee8-9cf1-e0e31c5edea7 1 50.00GiB /dev/vdb
> 2517a387-e060-46d1-9be7-9535802333c7 2 50.00GiB /dev/vdc
> 763dbe5e-8b16-4330-8730-8b60e245056b 3 50.00GiB /dev/vdd
> 180abbc2-4426-4f9c-a711-7735e19536d4 4 50.00GiB /dev/vde
> 666799fd-0413-42ce-bac4-a96e3e855ea2 5 50.00GiB /dev/vdf
> a6af3e09-8469-4e57-9fa0-9d82e6c8faf1 6 50.00GiB /dev/vdg
> e2b8a73e-2e37-4eb8-a8cb-71721a96b358 7 50.00GiB /dev/vdh
> 3fa65e67-88f6-48cc-9292-9336220e19a8 8 2.00GiB /dev/vdi
> 5a238ef4-e143-4b84-b698-347a1ceb7aa7 9 2.00GiB /dev/vdj
> 9794c5b4-8a9e-40d0-9774-b672034ef22b 10 2.00GiB /dev/vdk
>
> Total devices size: 356.01GiB
>
>
> -- cut -- cut --
> Each information is in its own row. The devices are listed with more
> information (disk uuid, id, size of each devices...)
> Nodesize, Leafsize, Sectorsize are separated by the filesystem size.
>
> The metadata/data profile are displayed (before this information was missed).
> Also the size of the data/metadata/system chunk are displayed.
>
>
> These changes are also available via github
> https://github.com/kreijack/btrfs-progs
> branch
> mkfs-verbose
>
> Changelog:
> v1: first issue (as RFC)
> v2: replaced "disks" with "devices" (suggested by Duncan)
> replaced "Feature" with "Incompat features" (suggested by Satoru)
> updated the comment of the documentation patch (suggested by Duncan)
> removed a duplicate "-q" in the documentation patch (suggested by Duncan)
> split the patch #6 in #6 and #7 to simplify the reading and review
>
> BR
> G.Baroncelli
>
next prev parent reply other threads:[~2014-12-18 2:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 20:14 [PATCH V2][BTRFS-PROGS] Improve output of mkfs.btrfs command Goffredo Baroncelli
2014-12-17 20:14 ` [PATCH 1/8] Add -v -q switches to mkfs.btrfs Goffredo Baroncelli
2014-12-25 1:19 ` Satoru Takeuchi
2014-12-17 20:14 ` [PATCH 2/8] Move group_profile_str() in utils.c Goffredo Baroncelli
2014-12-25 1:20 ` Satoru Takeuchi
2014-12-17 20:14 ` [PATCH 3/8] Add verbose option to btrfs_add_to_fsid() Goffredo Baroncelli
2014-12-25 1:28 ` Satoru Takeuchi
2014-12-17 20:14 ` [PATCH 4/8] Add strdup in btrfs_add_to_fsid() to track the device path Goffredo Baroncelli
2014-12-25 1:29 ` Satoru Takeuchi
2014-12-17 20:14 ` [PATCH 5/8] Return the fsid from make_btrfs() Goffredo Baroncelli
2014-12-25 2:44 ` Satoru Takeuchi
2014-12-25 9:22 ` Goffredo Baroncelli
2014-12-17 20:14 ` [PATCH 6/8] Track the size of the chunk created Goffredo Baroncelli
2014-12-17 20:14 ` [PATCH 7/8] Print the summary Goffredo Baroncelli
2014-12-17 20:14 ` [PATCH 8/8] Add -v and -q switches in the mkfs.btrfs man page Goffredo Baroncelli
2014-12-17 22:38 ` [PATCH V2][BTRFS-PROGS] Improve output of mkfs.btrfs command Martin Steigerwald
2014-12-18 2:28 ` Anand Jain [this message]
2015-03-23 23:46 ` David Sterba
2015-03-25 19:07 ` Goffredo Baroncelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54923BB4.9030500@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=kreijack@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).