linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: David Sterba <dsterba@suse.cz>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/6] btrfs-progs: corrupt block, add missing break to option I
Date: Fri, 19 Dec 2014 10:49:11 -0600	[thread overview]
Message-ID: <54945707.50605@redhat.com> (raw)
In-Reply-To: <42b74f46eeeae9aa4b93e4316d56e7a165a492ae.1419005022.git.dsterba@suse.cz>

On 12/19/14 10:06 AM, David Sterba wrote:
> Using -I would imply -d.
> 
> Resolves-Coverity-CID: 1258792
> Signed-off-by: David Sterba <dsterba@suse.cz>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  btrfs-corrupt-block.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/btrfs-corrupt-block.c b/btrfs-corrupt-block.c
> index af9ae4d4047c..aeeb1b298f66 100644
> --- a/btrfs-corrupt-block.c
> +++ b/btrfs-corrupt-block.c
> @@ -1096,6 +1096,7 @@ int main(int ac, char **av)
>  				break;
>  			case 'I':
>  				corrupt_item = 1;
> +				break;
>  			case 'd':
>  				delete = 1;
>  				break;
> 


  reply	other threads:[~2014-12-19 16:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-19 16:06 [PATCH 0/6] Btrfs progs, coverity fixes for 3.18 David Sterba
2014-12-19 16:06 ` [PATCH 1/6] btrfs-progs: corrupt block, add missing break to option I David Sterba
2014-12-19 16:49   ` Eric Sandeen [this message]
2014-12-19 16:06 ` [PATCH 2/6] btrfs-progs: corrupt block, add break after option U David Sterba
2014-12-19 16:49   ` Eric Sandeen
2014-12-19 16:06 ` [PATCH 3/6] btrfs-progs: fragments, close output file on error David Sterba
2014-12-19 16:50   ` Eric Sandeen
2014-12-19 16:06 ` [PATCH 4/6] btrfs-progs: check result of first_cache_extent David Sterba
2014-12-19 16:56   ` Eric Sandeen
2014-12-19 17:03     ` David Sterba
2014-12-19 16:06 ` [PATCH 5/6] btrfs-progs: check allocation result in add_clone_source David Sterba
2014-12-19 16:58   ` Eric Sandeen
2014-12-19 16:06 ` [PATCH 6/6] btrfs-progs: let btrfs_free_path accept NULL David Sterba
2014-12-19 16:58   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54945707.50605@redhat.com \
    --to=sandeen@redhat.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).